Add SSL.Context.set_keylog_callback#910
Merged
Merged
Conversation
fd90d19 to
a19d145
Compare
|
pyca/cryptography#5187 has been merged. What is blocking this? |
Member
Author
|
There's no cryptography release that includes pyca/cryptography#5187 yet. Tests are passing here because |
Member
Author
|
I've rebase the PR onto master, all tests are passing now with cryptography 3.0 - thanks! 🍰 Codecov is complaining about one missed line, but that seems to be a false-positive to me. |
reaperhulk
approved these changes
Jul 28, 2020
reaperhulk
left a comment
Member
There was a problem hiding this comment.
codecov has constant problems. I agree it appears spurious.
Member
Author
|
Yes, we suffer from that too. Thanks for the super quick merge again! ❤️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This builds on the bindings added in pyca/cryptography#5187. :)
The PR should be ready, but this depends on the next minor cryptography release.