raise exception on any non-zero exit code from subprocesses #492
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abelsonlive
reviewed
Jan 10, 2022
streamparse/util.py
Outdated
| else sudo(cmd, user=user, **kwargs) | ||
| ) | ||
| if command_result.return_code != 0: | ||
| raise ValueError() |
Contributor
There was a problem hiding this comment.
I wonder if changing this to a SystemExit would allow us to not have to modify how fabric works?
Contributor
Author
There was a problem hiding this comment.
I just tried this locally, and unfortunately it results in the deploy command not exiting
Contributor
There was a problem hiding this comment.
Got it, I changed this to the more standard RuntimeError
Contributor
|
@emmett9001 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request causes most streamparse subprocesses to raise exceptions when they return nonzero exit codes. Combined with Parsely/fabric#4, this causes streamparse-based topology deployments to exit when the virtualenv installation fails on one or more hosts.