Introduce virtual device#4091
Merged
Merged
Conversation
a7274ef to
9976bb2
Compare
9976bb2 to
2b5dd6e
Compare
Contributor
|
Let's make sure that we cover the explict sharded cases, where we want to avoid the initial unpartitioned data transfer. We will have to double-check, but |
Collaborator
Author
|
Notes after chat with Yeounoh:
|
Collaborator
|
This is the only entry for the transfer data to device. |
6a326ec to
32ff407
Compare
Collaborator
Author
|
Remaining implementation details before I can start testing:
|
f64c1a5 to
01fa14d
Compare
ccb5384 to
0adcbf7
Compare
yeounoh
reviewed
Nov 15, 2022
jonb377
reviewed
Nov 15, 2022
yeounoh
reviewed
Nov 15, 2022
yeounoh
reviewed
Nov 15, 2022
yeounoh
reviewed
Nov 15, 2022
yeounoh
reviewed
Nov 15, 2022
yeounoh
reviewed
Nov 15, 2022
yeounoh
suggested changes
Nov 15, 2022
yeounoh
left a comment
Contributor
There was a problem hiding this comment.
I added some comments, looking good -- great work @steventk-g :)
yeounoh
reviewed
Nov 18, 2022
yeounoh
reviewed
Nov 18, 2022
yeounoh
reviewed
Nov 18, 2022
yeounoh
reviewed
Nov 18, 2022
yeounoh
approved these changes
Nov 18, 2022
yeounoh
left a comment
Contributor
There was a problem hiding this comment.
LGTM, thank you @steventk-g 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes in this PR
XLA_USE_SPMD_xla_mark_sharding. The re-downloading path is preserved so thatXLA_USE_SPMD=0still works as well.xla:0fromxm.xla_device(). At this point, users should expect all tensors to be treated as if they are on the virtual device when SPMD is enabled.