Document environment variables#4273
Conversation
| - Verbosity level for GRPC, e.g. INFO, ERROR, etc. | ||
| type: string | ||
| default_value: "ERROR" | ||
| TPU_ML_PLATFORM: |
There was a problem hiding this comment.
lol I felt like we should not make this configurable
There was a problem hiding this comment.
I wonder if we should include it here for the sake of documentation, and remark that it shouldn't be changed. My intention in including it was just to cover every environment variable that shows up in this repo.
Line 66 in f858155
JackCaoG
left a comment
There was a problem hiding this comment.
Mostly LGTM. Thanks for putting this together! Is it possible to group similar env var for better reading expericence?
For example we can split them into
- XRT related
- Build related
- Debug related
- Feature enablement
- Device configuration
- Distributed related
- ...
will-cromar
left a comment
There was a problem hiding this comment.
Wow! Thanks for laying all of this out. LGTM at least for the variables I know about
I agree with Jack's comment that it would be clearer if you categorized the variables, especially separating the build-time variables from the run-time variables and separating the XRT configuration from the rest.
@JackCaoG Do we also want some designation of which variables are stable and which might get removed in the future? Or are we committed to actually supporting all of these?
fd335cc to
77cfea1
Compare
|
yea I think in this or I am fine with only group them by cateratory. We can update it based on stable/to_be_removed in a follow up pr. |
77cfea1 to
e79223b
Compare
Created a yaml file that captures all relevant environment variables with description, type, and default value.
Variables are grouped into the following: