Skip to content

fix panic on go 1.22.x #44

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
quasilyte merged 12 commits into from
Apr 18, 2024
Merged

fix panic on go 1.22.x #44

quasilyte merged 12 commits into from
Apr 18, 2024

Conversation

@peczenyj
Copy link
Contributor

@peczenyj peczenyj commented Apr 18, 2024 •
edited
Loading

This fixes issue #43

there is a panic when using golang.org/x/tools@v0.11.0 on go 1.22

the minimal version that works is golang.org/x/tools@v0.13.0 -- the latest seems ok but it does not works on go 1.18

I add tests with go from 1.18 to 1.22

however I advise to bump go.mod to use 1.21 or 1.22 and drop support to older go versions - but this is not my call

changelog of tools

[v0.13.0: go/analysis/analysistest: give better hint in SuggestedFix assertion](https://github.com/golang/tools/releases/tag/v0.13.0)
@[adonovan](https://github.com/adonovan) adonovan tagged this Sep 5, 2023
Also, better documentation on the underlying cause.

Change-Id: I0ee93b6e9f2ada52d9a32a322b77fda783ddf076
Reviewed-on: https://go-review.googlesource.com/c/tools/+/525215
TryBot-Result: Gopher Robot <gobot@golang.org>
Run-TryBot: Alan Donovan <adonovan@google.com>
Reviewed-by: Robert Findley <rfindley@google.com>

[v0.12.0: gopls/internal/lsp/source: enable new defers analyzer](https://github.com/golang/tools/releases/tag/v0.12.0)
@[adonovan](https://github.com/adonovan) adonovan tagged this Aug 7, 2023
This change enables the new defers analyzer in gopls.
It also adds it to the vet compatibility test.
A follow-up change will add it to vet itself.

Also, remove stray backquote in doc comment.

Updates golang/go#60048

Change-Id: I42f09bb79fcbe4e48593dd32fd066ddd39b9626f
Reviewed-on: https://go-review.googlesource.com/c/tools/+/502975
Run-TryBot: Alan Donovan <adonovan@google.com>
Auto-Submit: Alan Donovan <adonovan@google.com>
Reviewed-by: Robert Findley <rfindley@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>

@peczenyj peczenyj changed the title DRAFT fix panic on go 1.22 fix panic on go 1.22 Apr 18, 2024
quasilyte
quasilyte reviewed Apr 18, 2024
View reviewed changes
quasilyte
quasilyte reviewed Apr 18, 2024
View reviewed changes
@peczenyj peczenyj changed the title fix panic on go 1.22 fix panic on go 1.22.x Apr 18, 2024
@quasilyte quasilyte merged commit 5237e80 into quasilyte:master Apr 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@quasilyte quasilyte quasilyte approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@peczenyj @quasilyte