Add puma plugin#300
Conversation
brunoprietog
left a comment
There was a problem hiding this comment.
This is great! Goodbye bin/dev. It would be nice to change the install generator to default to include the plugin in the Puma configuration in the development environment.
|
@brunoprietog Should have everything addressed! I also removed the bin/dev and procfile stuff. Let me know if you want to keep that around |
brunoprietog
left a comment
There was a problem hiding this comment.
I'm not a maintainer, I just leave my comments that I think could be useful to help this merge more quickly.
I would really love to leave bin/dev, and actuallty this same change could be very good for dartsas-rails, jsbundling-rails and cssbundling-rails if the maintainers agree.
I think it would be good to add a description to the PR. Leave bin/dev is a very convincing argument at least for me.
|
Nice! I have no further comments from me at least. Hopefully it will merge soon and we will have the same for the other gems that force us to use bin/dev. |
|
I think I understand why adding Puma support is valuable; but what's the rationale for deleting |
|
It won't break it, it would only be for new applications. |
|
There is a developer workflow that is well-documented and expected to work. Unless the files prevent users from using a puma plugin, they should not be removed. And if they do, I want to understand why. |
|
How could you debug using In my opinion, everything should just work in a single terminal. Why would you want to have two ways if one works better than the other? I don't understand why it would be better to use I mean, why would you want to use foreman? That means adding one more dependency. It also means that in some cases, newvie developers have to use |
|
@flavorjones How would you feel about reverting all but the puma plugin and have the discussion around bin/dev in a separate PR? |
|
@npezza93 Yup, that would be great, thank you! |
|
@flavorjones Should be all set! |
|
@npezza93 Thank you! I've squashed your commits to leave a clean history, and I've reworked the README a bit to feature the Puma plugin more prominently. This is great work, thank you! Worked great for me when I tried it out on my local dev environment. |
and add a CHANGELOG entry
@brunoprietog So you can spin up other processes too, such as Redis or Sidekiq. |
|
Redis can be started as a service just like PostgreSQL or MySQL. And Sidekiq you can also manage it with puma, so a single command is enough and you can easily debug. |
|
I tried adding the (Problem solved, happened due to a conflict with the sassc-rails gem) |
This adds a puma plugin that runs watch mode only in development.