remove inter font before upgrading using the npx script#469
Merged
flavorjones merged 1 commit intoJan 24, 2025
Merged
Conversation
59cbc83 to
b5aac18
Compare
Member
|
Good catch! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In order to rebase other prs i opened i had to upgrade my local installation. Since i don't have npx installed, the task was aborted before the inter font was removed from the layout.
If for some reason (like in my case) you can't run the upgrade tool or it fails, you have to manually upgrade and also manually edit the layout to remove the inter font. This can be avoided if we remove it before running the npx upgrade tool.
other than that, it works great. 😄 . I tried upgrading manually and using the tool and in all cases works perfectly.