fix: unnecessary stylesheet_link_tag for tailwind#473
Merged
Conversation
In Rails 8, propshaft detects `:app` and loads all the css files under app/assets/stylesheets, so we may not need this explicit tag for tailwind. On installation, omit the tailwind stylesheet link tag if `:app` is already being passed to stylesheet_link_tag in the layout. On upgrade, remove the tailwind stylesheet link tag if `:app` is already being passed to stylesheet_link_tag in the layout.
be02dd2 to
7ae7a06
Compare
|
This doesn't seem to be the behavior we need, since, if you use Tailwind, the With this, we'd be including default CSS files that have tailwind syntax that wouldn't be appropriate. |
|
Ignore me, just saw #474 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In Rails 8, propshaft detects
:appand loads all the css files under app/assets/stylesheets, so we may not need this explicit tag for tailwind.On installation, omit the tailwind stylesheet link tag if
:appis already being passed to stylesheet_link_tag in the layout.On upgrade, remove the tailwind stylesheet link tag if
:appis already being passed to stylesheet_link_tag in the layout.See related discussion at #412