This repository was archived by the owner on Apr 18, 2026. It is now read-only.
fix: position top / style for bootstrap 4/5#1890
Merged
Merged
Conversation
risadams
approved these changes
Nov 3, 2022
risadams
left a comment
Contributor
There was a problem hiding this comment.
It's fine that BS3 isn't updated, anything less than 4 is mostly legacy code at this point.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Position top sometimes wrong, i fix it by replacing
prop('scrollHeight')byouterHeight(true)And i fix style box-shadow when dropdown is on top and with bootstrap 4/5 (not bootstrap 3 cause i don't know this version and it pretty outdated..)