shell/completion.nu: add support for sudo, empty triggers and pacman preview#1
Closed
jochumdev wants to merge 1 commit into
Closed
shell/completion.nu: add support for sudo, empty triggers and pacman preview#1jochumdev wants to merge 1 commit into
jochumdev wants to merge 1 commit into
Conversation
Author
|
I forgot to promote It's now it's own project: https://sr.ht/~jochumdev/show/ |
…preview. As noted in junegunn#4630 here are my improvements. - Add sudo support - Add support for empty trigers (I dont recommend that though) - Add a fzf preview for pacman packages using `pacman -Si <pkg>` - Add support for paru (it is just an extension wrapper to pacman) - Fix neatpick remove a not required `do`
ed0d8eb to
8bb775f
Compare
Owner
|
Hi @jochumdev, Thanks for your contributions! I've integrated the following features from your PR into the current codebase (which has been significantly reworked since December):
These are included in commit 10787b85 with a I left out the empty trigger support (as you noted yourself, it's not recommended) and the closure-to-def refactor, since the codebase structure has changed quite a bit. Closing this PR since the relevant changes have been merged. Thanks again for the improvements! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
As noted in junegunn#4630 here are my improvements.
pacman -Si <pkg>doThank you for this, I like it a lot.
Kind regards,
René