Bug of post_setup_fn #6
Description
Got this error when introducing a new example without setting up post_setup_fn. I think we shouldn't assume post_setup_fn exists in every task.
Traceback (most recent call last):
File "tpu_app.py", line 72, in <module>
File "/Users/weichiang/Workspace/research/sky-experiments/prototype/sky/execution.py", line 409, in execute
runner.run()
File "/Users/weichiang/Workspace/research/sky-experiments/prototype/sky/execution.py", line 281, in run
commands = fn(self.cluster_ips)
TypeError: 'NoneType' object is not callable
To fix this, we can add an one line check
if task.post_setup_fn is not None:
before this code segment
https://github.com/concretevitamin/sky-experiments/blob/154549c0eec432d366681ac063dacdbafdaa6475/prototype/sky/execution.py#L371-L374
Metadata
Metadata
Assignees
Labels
No labels