[Perf] Remote API server checking network connection times out slowly #6263
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
If we just need one of these to be live, could we also test it such that
instead of
? |
Collaborator
Author
|
Will switch to that! |
Comment on lines
-2613
to
+2618
| # `sky serve up`. If we have controller's head_ip available and it is ssh-reachable, | ||
| # `sky serve up`. If we have controller's head_ip available and it is ssh-reachable, |
Collaborator
There was a problem hiding this comment.
I am so confused on what is happening here. Not blocking approval because it isn't important by any means - I'm just confused.
Collaborator
Author
There was a problem hiding this comment.
I have no idea what happened here
Collaborator
|
If 8.8.8.8 is generally more reliable than 1.1.1.1 we can still keep it as the first tried entry |
SeungjinYang
approved these changes
Jul 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes for
sky statusfor a remote api server, it checks the network connection by pinging endpoints. It tests two endpoints with 3 retries each for a three second timeout. This means thathttps://1.1.1.1is tested for 9 seconds before testing google's endpointhttps://8.8.8.8. This PR swaps the order (google's endpoint first) and then the timeout is reduced to 1s instead of 3s. This was tested without any jobs running.Tested (run the relevant ones):
bash format.sh/smoke-test(CI) orpytest tests/test_smoke.py(local)/smoke-test -k test_name(CI) orpytest tests/test_smoke.py::test_name(local)/quicktest-core(CI) orpytest tests/smoke_tests/test_backward_compat.py(local)