[Dashboard] Add tour for dashboard #6301

Michaelvll · 2025-07-18T22:43:29Z

Tested (run the relevant ones):

Code formatting: install pre-commit (auto-check on commit) or bash format.sh
Any manual or new tests for this PR (please specify below)
All smoke tests: /smoke-test (CI) or pytest tests/test_smoke.py (local)
Relevant individual tests: /smoke-test -k test_name (CI) or pytest tests/test_smoke.py::test_name (local)
Backward compatibility: /quicktest-core (CI) or pytest tests/smoke_tests/test_backward_compat.py (local)

…-new

cursor

Bug: Clipboard Copy Errors: Null Checks and Promise Handling

The copyDashboardCodeBlock function lacks robust error handling. It is missing null checks for DOM element queries (e.g., closest, querySelector), which can lead to TypeError crashes if the expected elements are not found. Additionally, the navigator.clipboard.writeText() call lacks a .catch() block, resulting in unhandled promise rejections if the clipboard operation fails.

sky/dashboard/src/hooks/useTour.js#L23-L36

skypilot/sky/dashboard/src/hooks/useTour.js

Lines 23 to 36 in b604940

    
           if (typeof window !== 'undefined') { 
        
             window['copyDashboardCodeBlock'] = function (button) { 
        
               const codeContainer = button.closest('.bg-gray-50').querySelector('pre'); 
        
               const codeBlock = codeContainer.querySelector('code.block'); 
        
               const text = codeBlock.textContent; 
        
               navigator.clipboard.writeText(text).then(() => { 
        
                 const originalSvg = button.innerHTML; 
        
                 button.innerHTML = 
        
                   '<svg xmlns="http://www.w3.org/2000/svg" width="24" height="24" viewBox="0 0 24 24" fill="none" stroke="currentColor" stroke-width="2" stroke-linecap="round" stroke-linejoin="round" class="lucide lucide-check h-5 w-5 text-green-600"><path d="m9 12 2 2 4-4"/></svg>'; 
        
                 setTimeout(() => { 
        
                   button.innerHTML = originalSvg; 
        
                 }, 2000); 
        
               }); 
        
             };

Fix in Cursor • Fix in Web

Was this report helpful? Give feedback by reacting with 👍 or 👎

Michaelvll and others added 16 commits July 17, 2025 17:39

init tour

48ff2ef

Merge branch 'master' of github.com:skypilot-org/skypilot into tour

78e81ac

Fix tour content

3d57511

Some progress

c5c013c

fixed ReferenceError: copyDashboardCodeBlock is not defined

f1d3ba2

reword

af5ae46

no overlay; add steps;

e6c74b3

title

92114d2

fix last two steps

933620c

arrow not displayed correctly

ce587c0

fix url colors

18efb20

arrow not working

dc738c4

box infra column correctly

0ff577f

add back title

cc2b344

Fix the button

1eea797

format

d0626ce

This comment was marked as outdated.

Sign in to view

Michaelvll added 2 commits July 18, 2025 15:45

fix start tour

4962196

fix

87817ec

This comment was marked as outdated.

Sign in to view

appearance update

a632b6a

This comment was marked as outdated.

Sign in to view

fix first visit

5be21eb

This comment was marked as outdated.

Sign in to view

Fix first time visit

b605c60

This comment was marked as outdated.

Sign in to view

concretevitamin and others added 3 commits July 19, 2025 06:23

reword

3cd492f

Merge branch 'master' of github.com:skypilot-org/skypilot into tour-new

aee6f93

Merge branch 'tour-new' of github.com:skypilot-org/skypilot into tour…

b52a804

…-new

This comment was marked as outdated.

Sign in to view

format

d3dcbcd

This comment was marked as outdated.

Sign in to view

Fix startTour initialization error (#6305)

1d6d36b

This comment was marked as outdated.

Sign in to view

concretevitamin added 4 commits July 20, 2025 07:25

Reword

08a154e

join slack

a01c0c5

fix another page -> start tour -> 404

fa38669

try to reduce delay

daa8a2a

concretevitamin approved these changes Jul 20, 2025

View reviewed changes

Michaelvll added 2 commits July 20, 2025 11:15

fix cluster box

fc65786

format

9077ab8

This comment was marked as outdated.

Sign in to view

Michaelvll added 2 commits July 20, 2025 20:29

Add users step

9a37b49

format

49c86a9

This comment was marked as outdated.

Sign in to view

concretevitamin and others added 2 commits July 20, 2025 21:16

minor reword

fc37fc2

fix copy icon

c4f305d

This comment was marked as outdated.

Sign in to view

format

9b9ec1a

This comment was marked as outdated.

Sign in to view

fix the infra dialog gap

edbb505

This comment was marked as outdated.

Sign in to view

fix

5d640f1

This comment was marked as outdated.

Sign in to view

Merge branch 'master' of github.com:skypilot-org/skypilot into tour-new

b604940

cursor bot reviewed Jul 21, 2025

View reviewed changes

Michaelvll enabled auto-merge (squash) July 21, 2025 06:25

Michaelvll merged commit af46f17 into master Jul 21, 2025
34 of 43 checks passed

Michaelvll deleted the tour-new branch July 21, 2025 06:33

	if (typeof window !== 'undefined') {
	window['copyDashboardCodeBlock'] = function (button) {
	const codeContainer = button.closest('.bg-gray-50').querySelector('pre');
	const codeBlock = codeContainer.querySelector('code.block');
	const text = codeBlock.textContent;
	navigator.clipboard.writeText(text).then(() => {
	const originalSvg = button.innerHTML;
	button.innerHTML =
	'<svg xmlns="http://www.w3.org/2000/svg" width="24" height="24" viewBox="0 0 24 24" fill="none" stroke="currentColor" stroke-width="2" stroke-linecap="round" stroke-linejoin="round" class="lucide lucide-check h-5 w-5 text-green-600"><path d="m9 12 2 2 4-4"/></svg>';
	setTimeout(() => {
	button.innerHTML = originalSvg;
	}, 2000);
	});
	};

[Dashboard] Add tour for dashboard #6301

[Dashboard] Add tour for dashboard #6301

Uh oh!

Conversation

Michaelvll commented Jul 18, 2025

Uh oh!

This comment was marked as outdated.

Uh oh!

This comment was marked as outdated.

Uh oh!

This comment was marked as outdated.

Uh oh!

This comment was marked as outdated.

Uh oh!

This comment was marked as outdated.

Uh oh!

This comment was marked as outdated.

Uh oh!

This comment was marked as outdated.

Uh oh!

This comment was marked as outdated.

Uh oh!

This comment was marked as outdated.

Uh oh!

This comment was marked as outdated.

Uh oh!

This comment was marked as outdated.

Uh oh!

This comment was marked as outdated.

Uh oh!

This comment was marked as outdated.

Uh oh!

This comment was marked as outdated.

Uh oh!

This comment was marked as outdated.

Uh oh!

cursor bot left a comment

Choose a reason for hiding this comment

Bug: Clipboard Copy Errors: Null Checks and Promise Handling

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants