Skip to content

Conversation

@cg505
Copy link
Collaborator

@cg505 cg505 commented Jul 28, 2025

  1. SkyServe will use the same strategy as managed jobs if no cloud storage is available. Description copied from controller_utils.translate_local_file_mounts_to_two_hop:
    This strategy will upload the local files to the controller first, using a
    normal rsync as part of sky.launch() for the controller. Then, when the
    controller launches the task, it will also use local file_mounts from the
    destination path of the first hop.

    Local machine/API server        Controller              Job cluster
    ------------------------  -----------------------  --------------------
    |      local path  ----|--|-> controller path --|--|-> job dst path   |
    ------------------------  -----------------------  --------------------
  1. Add a config toggle that will force this file mount method even if cloud storage is enabled.

docs TODO

Tested (run the relevant ones):

  • Code formatting: install pre-commit (auto-check on commit) or bash format.sh
  • Any manual or new tests for this PR (please specify below)
  • All smoke tests: /smoke-test (CI) or pytest tests/test_smoke.py (local)
  • Relevant individual tests: /smoke-test -k test_name (CI) or pytest tests/test_smoke.py::test_name (local)
  • Backward compatibility: /quicktest-core (CI) or pytest tests/smoke_tests/test_backward_compat.py (local)

@cg505 cg505 requested a review from cblmemo July 28, 2025 17:51
Copy link
Collaborator

@cblmemo cblmemo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this @cg505 ! LGTM.

@cg505
Copy link
Collaborator Author

cg505 commented Jul 28, 2025

/smoke-test --managed-jobs

@cg505
Copy link
Collaborator Author

cg505 commented Jul 28, 2025

/smoke-test --serve

@cg505 cg505 merged commit 2b73e2f into skypilot-org:master Jul 28, 2025
22 of 26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants