Skip to content

Conversation

@DanielZhangQD
Copy link
Collaborator

Skip basic auth for /api/health only, which is required for health check in kubelet

Tested (run the relevant ones):

  • Code formatting: install pre-commit (auto-check on commit) or bash format.sh
  • Any manual or new tests for this PR (please specify below)
    • Curl /api/health succeeds without credentials
    • sky api status/logs/cancel requires credentials
  • All smoke tests: /smoke-test (CI) or pytest tests/test_smoke.py (local)
  • Relevant individual tests: /smoke-test -k test_name (CI) or pytest tests/test_smoke.py::test_name (local)
  • Backward compatibility: /quicktest-core (CI) or pytest tests/smoke_tests/test_backward_compat.py (local)

@DanielZhangQD DanielZhangQD requested a review from aylei July 29, 2025 02:26
@DanielZhangQD DanielZhangQD marked this pull request as ready for review July 29, 2025 02:26
Copy link
Collaborator

@aylei aylei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aylei aylei merged commit 8c6285d into master Jul 29, 2025
15 checks passed
@aylei aylei deleted the 22480 branch July 29, 2025 02:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants