Skip to content

Add spot pricing for Nebius #6478

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Michaelvll merged 2 commits into from
Aug 1, 2025
Merged

Add spot pricing for Nebius #6478

Michaelvll merged 2 commits into from
Aug 1, 2025

Conversation

@makhalin
Copy link
Contributor

@makhalin makhalin commented Aug 1, 2025

Nebius introduced spot-like instances called Preemtible VMs. This PR upgrades the pricing fetcher to support new types of instances.

Tested (run the relevant ones):

  • Code formatting: install pre-commit (auto-check on commit) or bash format.sh
  • Any manual or new tests for this PR (please specify below)
    • local run generated spot pricing in SpotPrice column for existing catalog lines.
  • All smoke tests: /smoke-test (CI) or pytest tests/test_smoke.py (local)
  • Relevant individual tests: /smoke-test -k test_name (CI) or pytest tests/test_smoke.py::test_name (local)
  • Backward compatibility: /quicktest-core (CI) or pytest tests/smoke_tests/test_backward_compat.py (local)

makhalin
makhalin commented Aug 1, 2025
View reviewed changes
sky/catalog/data_fetchers/fetch_nebius.py
Returns:
str: The formatted string representation of the decimal.
"""
formatted_value = f'{value:f}'.rstrip('0').rstrip('.')
Copy link
Contributor Author

@makhalin makhalin Aug 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

note: there was a small bug that strips 0 from 10.

Michaelvll
Michaelvll approved these changes Aug 1, 2025
View reviewed changes
Copy link
Collaborator

@Michaelvll Michaelvll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @makhalin! LGTM! Should be good to merge if the tests pass

@Michaelvll Michaelvll merged commit c39fdda into skypilot-org:master Aug 1, 2025
15 checks passed
@Michaelvll
Copy link
Collaborator

Michaelvll commented Aug 1, 2025 •
edited
Loading

@makhalin, it seems the catalog fetcher CI failed with the following error:

  File "/home/runner/catalogs-venv/lib/python3.10/site-packages/sky/catalog/data_fetchers/fetch_nebius.py", line 122, in _estimate_platforms
    compute_instance_spec=compute().CreateInstanceRequest(
TypeError: CreateInstanceRequest.__init__() got an unexpected keyword argument 'preemptible'

Do you see how to fix this?

@makhalin
Copy link
Contributor Author

makhalin commented Aug 1, 2025

@makhalin, it seems the catalog fetcher CI failed with the following error:

  File "/home/runner/catalogs-venv/lib/python3.10/site-packages/sky/catalog/data_fetchers/fetch_nebius.py", line 122, in _estimate_platforms
    compute_instance_spec=compute().CreateInstanceRequest(
TypeError: CreateInstanceRequest.__init__() got an unexpected keyword argument 'preemptible'

Do you see how to fix this?

My bad #6481

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Michaelvll Michaelvll Michaelvll approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@makhalin @Michaelvll