-
Notifications
You must be signed in to change notification settings - Fork 919
[Docs] Add SDK Example to Quick Start #6561
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
** will update example for the above mentioned PR if said PR gets merged first. |
| * SSH access from SkyPilot API server host to all remote machines | ||
| * All nodes within a SSH Node Pool must have access to port 6443 to its peers (e.g., same VPC). | ||
| * Port 6443 doesn't have to be open to machines outside of the network | ||
| * All nodes within a SSH Node Pool must have access to port 6443 to its peers (e.g., same VPC). Port 6443 doesn't have to be open to machines outside of the network. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
apparently indented bullet points did not work :(... Added this fix here as a side thing
|
|
||
| .. code-block:: yaml | ||
| .. tab-item:: CLI | ||
| :sync: cli |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I actually did not know about this :sync:, TIL! Gonna modify some of my older docs with this nifty little trick.
SeungjinYang
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @kyuds! verified the python code works on my end as well.
Currently, quickstart in the docs only shows the yaml file example using the CLI. This PR implements the same quickstart example using the skypilot sdk
Disclaimer: tested the code in the quickstart example without the A100:8 accelerator parameter. Im gpu poor... Code works when using
sky.Resources(infra='aws')Tested (run the relevant ones):
bash format.sh/smoke-test(CI) orpytest tests/test_smoke.py(local)/smoke-test -k test_name(CI) orpytest tests/test_smoke.py::test_name(local)/quicktest-core(CI) orpytest tests/smoke_tests/test_backward_compat.py(local)