[Core] last_event not populated in cluster records #6615
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: kyuds References: PR #6609
Collaborator
Author
|
/quicktest-core |
Collaborator
Author
|
/smoke-test |
SeungjinYang
previously approved these changes
Aug 11, 2025
Collaborator
SeungjinYang
left a comment
There was a problem hiding this comment.
Thanks @lloyd-brown for the fix!
Need to rebase latest master and use cluster hash for retrieving events
query last event by cluster hash
Collaborator
Author
|
/smoke-test |
Collaborator
Author
|
/quicktest-core |
SeungjinYang
approved these changes
Aug 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Co-authored-by: kyuds
References: PR #6609 and issue #6606.
This PR addresses the cluster record not being populated in functions that return these records. It also handles situations where the cluster event table might not exist for backwards compatibility.
Tested (run the relevant ones):
bash format.sh/smoke-test(CI) orpytest tests/test_smoke.py(local)/smoke-test -k test_name(CI) orpytest tests/test_smoke.py::test_name(local)/quicktest-core(CI) orpytest tests/smoke_tests/test_backward_compat.py(local)