Avoid inserting duplicate events #6620
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SeungjinYang
commented
Aug 11, 2025
sky/execution.py
Outdated
Comment on lines
-479
to
-483
Collaborator
Author
There was a problem hiding this comment.
It's debatable whether this should be deleted, I'm open to keeping it.
Though if we're keeping it we should move it to after job_id definition and include the job id in the event row
Collaborator
There was a problem hiding this comment.
I'm fine with removing for now. The user will know if their job starts running anyway.
lloyd-brown
requested changes
Aug 11, 2025
sky/global_user_state.py
Outdated
Collaborator
There was a problem hiding this comment.
You'll need to add the event_type in the call from get_cluster_from_name() and get_clusters_from_history() after rebase on master.
Collaborator
|
Do you want terminate entries for terminated clusters in same PR? If so 02dd13e#diff-db4566a60e392e4076a1a2bc4eaa56e57c4c2a060b23ff98e8b7b71e3e3d35f1L750 |
c6d0e87 to
eb95a20
Compare
Collaborator
Author
|
/quicktest-core |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For
All nodes up + ray cluster healthy.message andtransitioning to INITmessage, do not add another row into the db if the last event for the cluster already has the same message.The PR also proposes deleting
Starting job executionmostly because this line has little to do with the state of the cluster.Tested (run the relevant ones):
bash format.sh/smoke-test(CI) orpytest tests/test_smoke.py(local)/smoke-test -k test_name(CI) orpytest tests/test_smoke.py::test_name(local)/quicktest-core(CI) orpytest tests/smoke_tests/test_backward_compat.py(local)