Retry on transient error when streaming API request #6807
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Aylei <rayingecho@gmail.com>
Collaborator
Author
|
/quicktest-core |
Collaborator
|
/smoke-test -k test_long_setup_run_script |
kevinmingtarja
approved these changes
Aug 21, 2025
Collaborator
kevinmingtarja
left a comment
There was a problem hiding this comment.
LGTM, thanks @aylei!
As a follow up, what do you think of adding a test similar to https://github.com/skypilot-org/skypilot/blob/2824cc15878b2eb3d43b04b0d0a24f1fbb4577b0/tests/load_tests/test_ssh_proxy.py, that stress tests these streaming API calls under different network conditions or with simulated network failures.
Michaelvll
reviewed
Aug 22, 2025
| @usage_lib.entrypoint | ||
| @server_common.check_server_healthy_or_start | ||
| @annotations.client_api | ||
| @rest.retry_transient_errors() |
Collaborator
There was a problem hiding this comment.
importing functions from the server module in the client is a bit weird. We can do a refactor in the future.
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test:
Launch with network issue, can be recovered by retry:
sky statussky api logs xxx(will not retry)Tested (run the relevant ones):
bash format.sh/smoke-test(CI) orpytest tests/test_smoke.py(local)/smoke-test -k test_name(CI) orpytest tests/test_smoke.py::test_name(local)/quicktest-core(CI) orpytest tests/smoke_tests/test_backward_compat.py(local)