Skip to content

Conversation

@SalikovAlex
Copy link
Contributor

Refactor list_instances to support pagination

To fix #6853

Tested (run the relevant ones):

  • Code formatting: install pre-commit (auto-check on commit) or bash format.sh
  • Any manual or new tests for this PR (please specify below)
  • All smoke tests: /smoke-test (CI) or pytest tests/test_smoke.py (local)
    2

@kevinmingtarja kevinmingtarja self-requested a review August 26, 2025 18:38
@kevinmingtarja
Copy link
Collaborator

/smoke-test -k test_minimal --nebius
/smoke-test -k test_launch_fast --nebius
/smoke-test -k test_nebius --nebius

@kevinmingtarja
Copy link
Collaborator

/smoke-test -k test_core --nebius
/smoke-test -k test_cli --nebius

Copy link
Collaborator

@kevinmingtarja kevinmingtarja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the fix @SalikovAlex!

I'll merge this to #6856 next and test more extensively there.

@kevinmingtarja kevinmingtarja merged commit 835c663 into skypilot-org:master Aug 26, 2025
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Nebius] Check for next_page_token in list_instances to keep on fetching until complete

2 participants