Fix coreweave k8s cluster smoke tests failures #6913
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
/smoke-test --kubernetes --env-file s3://buildkite-configfile-test/config.yaml |
* only enable aws for remote api server in test_docker_storage_mounts * fix is_remote_server_test()
Collaborator
Author
|
More context from @kevinmingtarja zpoint#82 (comment) |
Collaborator
|
/smoke-test --kubernetes --env-file s3://buildkite-configfile-test/config.yaml |
Collaborator
Author
|
/smoke-test --kubernetes --env-file s3://buildkite-configfile-test/config.yaml |
kevinmingtarja
approved these changes
Aug 29, 2025
Collaborator
kevinmingtarja
left a comment
There was a problem hiding this comment.
LGTM, thanks @zpoint! This gets us to 64/93 tests 🟢. I'll follow up with another PR soon.
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
USER_ENV, which is not supported via API endpoints and service accounts token(The user will fixed if we use that,USER_ENVwon't work then)Tested (run the relevant ones):
bash format.sh/smoke-test(CI) orpytest tests/test_smoke.py(local)/smoke-test -k test_name(CI) orpytest tests/test_smoke.py::test_name(local)/quicktest-core(CI) orpytest tests/smoke_tests/test_backward_compat.py(local)