Skip to content

Conversation

@aylei
Copy link
Collaborator

@aylei aylei commented Aug 30, 2025

Redo #6889 and fix the race issue, the fix is included in the 9a68691 commit

Test:

  1. Manual test passed:
$ sky launch -c c1 -y --cpus 2+ --cloud kubernetes
$ python test.py
$ cat test.py
from sky.client import sdk
import threading

threads = []
for i in range(30):
    thread = threading.Thread(target=sdk.tail_logs, args=('c1', None, True), daemon=True)
    threads.append(thread)
    thread.start()

for thread in threads:
    thread.join()
  1. Unit test case:
    async def test_get_request_async_race_condition(isolated_database):

Tested (run the relevant ones):

  • Code formatting: install pre-commit (auto-check on commit) or bash format.sh
  • Any manual or new tests for this PR (please specify below)
  • All smoke tests: /smoke-test (CI) or pytest tests/test_smoke.py (local)
  • Relevant individual tests: /smoke-test -k test_name (CI) or pytest tests/test_smoke.py::test_name (local)
  • Backward compatibility: /quicktest-core (CI) or pytest tests/smoke_tests/test_backward_compat.py (local)

aylei added 3 commits August 30, 2025 15:18
Signed-off-by: Aylei <rayingecho@gmail.com>
Signed-off-by: Aylei <rayingecho@gmail.com>
@aylei
Copy link
Collaborator Author

aylei commented Aug 30, 2025

/quicktest-core
/smoke-test -k basic

@aylei aylei marked this pull request as ready for review August 30, 2025 15:51
Copy link
Collaborator

@Michaelvll Michaelvll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix @aylei! LGTM

@Michaelvll
Copy link
Collaborator

/smoke-test --kubernetes --remote-server

@aylei
Copy link
Collaborator Author

aylei commented Aug 31, 2025

/smoke-test --kubernetes --remote-server

https://buildkite.com/skypilot-1/smoke-tests/builds/2952#_ The failure was fixed in #6967

@aylei
Copy link
Collaborator Author

aylei commented Aug 31, 2025

/smoke-test --kubernetes --remote-server

@aylei
Copy link
Collaborator Author

aylei commented Sep 1, 2025

/smoke-test --kubernetes --remote-server

@aylei aylei merged commit 5d841aa into master Sep 1, 2025
17 checks passed
@aylei aylei deleted the redo-aiosqlite branch September 1, 2025 02:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants