Skip to content

Conversation

@rohansonecha
Copy link
Collaborator

This PR converts the job IDs passed to the server to strings in the download logs request from the cluster detail page. This fixes an issue where the download button works from the cluster job detail page but not the cluster detail page. The reason why it works for the cluster job detail page is that we were parsing the job id from the url which by default will be a string.

I manually verified that the download logs button from the cluster detail page is now working.

Tested (run the relevant ones):

  • Code formatting: install pre-commit (auto-check on commit) or bash format.sh
  • Any manual or new tests for this PR (please specify below)
  • All smoke tests: /smoke-test (CI) or pytest tests/test_smoke.py (local)
  • Relevant individual tests: /smoke-test -k test_name (CI) or pytest tests/test_smoke.py::test_name (local)
  • Backward compatibility: /quicktest-core (CI) or pytest tests/smoke_tests/test_backward_compat.py (local)

@rohansonecha rohansonecha merged commit 804be0d into master Sep 3, 2025
16 checks passed
@rohansonecha rohansonecha deleted the fix-cluster-download branch September 3, 2025 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants