Skip to content

Conversation

@SeungjinYang
Copy link
Collaborator

@SeungjinYang SeungjinYang commented Sep 4, 2025

  1. wait for preloading to complete before fetching cluster data. since cluster data is fetched during preloading, this avoids duplicate API calls.
  2. allow coordination between dashboard cache and preloader so _refreshInBackground does not refresh data that has recently been preloaded.

Tested (run the relevant ones):

  • Code formatting: install pre-commit (auto-check on commit) or bash format.sh
  • Any manual or new tests for this PR (please specify below)
  • All smoke tests: /smoke-test (CI) or pytest tests/test_smoke.py (local)
  • Relevant individual tests: /smoke-test -k test_name (CI) or pytest tests/test_smoke.py::test_name (local)
  • Backward compatibility: /quicktest-core (CI) or pytest tests/smoke_tests/test_backward_compat.py (local)

@SeungjinYang SeungjinYang marked this pull request as ready for review September 4, 2025 02:31
Copy link
Collaborator

@rohansonecha rohansonecha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch @SeungjinYang!

@SeungjinYang SeungjinYang merged commit 68dfaa5 into master Sep 4, 2025
16 checks passed
@SeungjinYang SeungjinYang deleted the consolidate-status-calls branch September 4, 2025 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants