-
Notifications
You must be signed in to change notification settings - Fork 918
Fixed k8s container ephemeral storage not reclaimed when using fusermount #7398
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Aylei <rayingecho@gmail.com>
Signed-off-by: Aylei <rayingecho@gmail.com>
|
/smoke-test --kubernetes |
DanielZhangQD
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
|
/smoke-test --kubernetes --remote-server -k test_fast_large_job_queue on kubernetes |
|
/smoke-test --kubernetes --remote-server -k test_fast_large_job_queue |
|
/smoke-test --kubernetes --remote-server -k test_fast_large_job_queue |
|
/smoke-test |
romilbhardwaj
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great catch @aylei ! 🔥
Signed-off-by: Aylei <rayingecho@gmail.com>
|
/smoke-test --kubernetes |
|
:gopher: 👀 |
fusermount-serverdid not close the fd to container'smntnamespace, thus themntnamespace will live until thefusermount-serverprocess exits. This will prevent the ephemeral storage used by containers being reclaimed.This PR fixes this issue by closing the fd to
mntnamespace after fusermount operation.Tested (run the relevant ones):
bash format.sh/smoke-test(CI) orpytest tests/test_smoke.py(local)/smoke-test -k test_name(CI) orpytest tests/test_smoke.py::test_name(local)/quicktest-core(CI) orpytest tests/smoke_tests/test_backward_compat.py(local)