Skip to content

Conversation

@aylei
Copy link
Collaborator

@aylei aylei commented Sep 26, 2025

fusermount-server did not close the fd to container's mnt namespace, thus the mnt namespace will live until the fusermount-server process exits. This will prevent the ephemeral storage used by containers being reclaimed.

This PR fixes this issue by closing the fd to mnt namespace after fusermount operation.

Tested (run the relevant ones):

  • Code formatting: install pre-commit (auto-check on commit) or bash format.sh
  • Any manual or new tests for this PR (please specify below)
  • All smoke tests: /smoke-test (CI) or pytest tests/test_smoke.py (local)
  • Relevant individual tests: /smoke-test -k test_name (CI) or pytest tests/test_smoke.py::test_name (local)
  • Backward compatibility: /quicktest-core (CI) or pytest tests/smoke_tests/test_backward_compat.py (local)

Signed-off-by: Aylei <rayingecho@gmail.com>
Signed-off-by: Aylei <rayingecho@gmail.com>
Signed-off-by: Aylei <rayingecho@gmail.com>
@aylei
Copy link
Collaborator Author

aylei commented Sep 26, 2025

/smoke-test --kubernetes
/smoke-test --kubernetes --remote-server

Copy link
Collaborator

@DanielZhangQD DanielZhangQD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@aylei
Copy link
Collaborator Author

aylei commented Sep 26, 2025

/smoke-test --kubernetes --remote-server -k test_fast_large_job_queue on kubernetes
/smoke-test --kubernetes -k test_helm_deploy_okta
/smoke-test --kubernetes -k test_skyserve

@aylei
Copy link
Collaborator Author

aylei commented Sep 26, 2025

/smoke-test --kubernetes --remote-server -k test_fast_large_job_queue

@aylei
Copy link
Collaborator Author

aylei commented Sep 27, 2025

/smoke-test --kubernetes --remote-server -k test_fast_large_job_queue

@aylei
Copy link
Collaborator Author

aylei commented Sep 27, 2025

/smoke-test

Copy link
Collaborator

@romilbhardwaj romilbhardwaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch @aylei ! 🔥

@aylei
Copy link
Collaborator Author

aylei commented Oct 1, 2025

/smoke-test --kubernetes

@SeungjinYang SeungjinYang merged commit 63394c9 into master Oct 2, 2025
22 checks passed
@SeungjinYang SeungjinYang deleted the fix-fusermount-storage branch October 2, 2025 20:49
@SeungjinYang SeungjinYang added this to the 0.10.4 milestone Oct 2, 2025
@rohansonecha
Copy link
Collaborator

:gopher: 👀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants