[jobs] limit the max number of jobs that can run/launch #7488
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, after skypilot-org#7051, we allowed the number of jobs launching/running to scale purely based on the controller resources. After this change, we set maximum values for the number that can run and launch, since there are some bottlenecks (e.g. DB) that will not necessarily scale with the instance resources.
Collaborator
Author
|
/smoke-test --managed-jobs |
Michaelvll
approved these changes
Oct 6, 2025
Collaborator
Michaelvll
left a comment
There was a problem hiding this comment.
Thanks @cg505! LGTM, as long as it is tested. : )
sky/jobs/scheduler.py
Outdated
| # Limit the number of jobs that can be running at once on the entire jobs | ||
| # controller cluster. It's hard to handle cancellation of more than 2000 jobs at | ||
| # once. | ||
| MAX_TOTAL_JOBS = 2000 |
Collaborator
There was a problem hiding this comment.
Add a TODO here for getting rid of this in the future
Collaborator
There was a problem hiding this comment.
Also, rename to MAX_RUNNING_JOBS? TOTAL sounds like including PENDING and finished jobs.
sky/jobs/scheduler.py
Outdated
| # LAUNCHES_PER_WORKER = 16 | ||
| # JOBS_PER_WORKER = 400 | ||
|
|
||
| # keep 1GB reserved after the controllers |
Collaborator
There was a problem hiding this comment.
Not aligned with the 2048 below?
Collaborator
Author
There was a problem hiding this comment.
this is just moved, but good catch
Michaelvll
reviewed
Oct 6, 2025
| CURRENT_HASH = os.path.expanduser('~/.sky/wheels/current_sky_wheel_hash') | ||
|
|
||
|
|
||
| def get_number_of_controllers() -> int: |
Collaborator
There was a problem hiding this comment.
should we add a lru cache for this?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, after #7051, we allowed the number of jobs launching/running to scale purely based on the controller resources.
After this change, we set maximum values for the number that can run and launch, since there are some bottlenecks (e.g. DB) that will not necessarily scale with the instance resources.
Tested (run the relevant ones):
bash format.sh/smoke-test(CI) orpytest tests/test_smoke.py(local)/smoke-test -k test_name(CI) orpytest tests/test_smoke.py::test_name(local)/quicktest-core(CI) orpytest tests/smoke_tests/test_backward_compat.py(local)