Skip to content

Conversation

@DanielZhangQD
Copy link
Collaborator

@DanielZhangQD DanielZhangQD commented Oct 29, 2025

Optimize internal calls to get managed job queue

Tested (run the relevant ones):

  • Code formatting: install pre-commit (auto-check on commit) or bash format.sh
  • Any manual or new tests for this PR (please specify below)
    • Update workspace config
      • Update private field for workspace with active resources
      • Update allowed_users for workspace with active resources
      • Update other config for workspace with active resources
    • Update skypilot config for workspace with active resources
    • Delete workspace with active resources
    • Delete user with active resources
    • Job controller upgrade - version mismatch and have non-terminated jobs
    • /queue api still works
    • Warning for managed jobs in consolidation mode
    • Check controller logs for managed jobs with name
    • HA recovery in consolidation mode
  • All smoke tests: /smoke-test (CI) or pytest tests/test_smoke.py (local)
  • Relevant individual tests: /smoke-test -k test_name (CI) or pytest tests/test_smoke.py::test_name (local)
  • Backward compatibility: /quicktest-core (CI) or pytest tests/smoke_tests/test_backward_compat.py (local)

@DanielZhangQD
Copy link
Collaborator Author

/smoke-test --managed-jobs --aws
/smoke-test --managed-jobs --kubernetes

@DanielZhangQD DanielZhangQD marked this pull request as ready for review October 29, 2025 05:32
@DanielZhangQD DanielZhangQD requested a review from aylei October 29, 2025 05:32
Copy link
Collaborator

@aylei aylei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! @DanielZhangQD

@DanielZhangQD DanielZhangQD merged commit 51d5cd3 into master Oct 30, 2025
22 checks passed
@DanielZhangQD DanielZhangQD deleted the 3605 branch October 30, 2025 01:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants