CredsStore validation for RegistryAuthLocator#1303
Merged
rnorth merged 8 commits intotestcontainers:masterfrom Mar 18, 2019
Merged
CredsStore validation for RegistryAuthLocator#1303rnorth merged 8 commits intotestcontainers:masterfrom
rnorth merged 8 commits intotestcontainers:masterfrom
Conversation
Contributor
Author
|
Could you guys help with what behaviour should be implemented for empty values? Options:
FYI: I explicitly fail test until this behaviour will be defined and implemented |
Member
|
Hi @NikitaZhevnitskiy When the I'd agree that it's a good idea to log, though - perhaps at WARN level? Thanks! |
rnorth
reviewed
Mar 17, 2019
core/src/test/java/org/testcontainers/utility/RegistryAuthLocatorTest.java
Outdated
Show resolved
Hide resolved
rnorth
reviewed
Mar 17, 2019
core/src/main/java/org/testcontainers/utility/RegistryAuthLocator.java
Outdated
Show resolved
Hide resolved
rnorth
requested changes
Mar 17, 2019
Member
rnorth
left a comment
There was a problem hiding this comment.
Just a couple of trivial comments from me but otherwise this is great, thank you!
rnorth
approved these changes
Mar 18, 2019
Member
rnorth
left a comment
There was a problem hiding this comment.
Great, thanks @NikitaZhevnitskiy
LGTM - will merge.
Member
|
Releasing this in 1.11.0 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes
RegistryAuthLocator: Add additional validation for existing keycredsStorebut empty valuePurpose
Define behaviour for RegistryAuthLocator on empty values in config
Offer:
Background Context
Currently experienced problems using testcontainers, I found existing issue for my problem and decided to help.
Potentially, put checks for all existing
keyswith empty stringsReferences
ref: #921