feat(types): type $fetch to match json serialization output#1002
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1002 +/- ##
==========================================
- Coverage 67.79% 67.66% -0.13%
==========================================
Files 60 60
Lines 6133 6161 +28
Branches 692 692
==========================================
+ Hits 4158 4169 +11
- Misses 1966 1982 +16
- Partials 9 10 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
danielroe
left a comment
There was a problem hiding this comment.
This is really great.
I only have one suggestion, so we can avoid the super-permissive object type. Otherwise 👌
Co-authored-by: Daniel Roe <daniel@roe.dev>
|
@danielroe Thanks 💚, I've also updated the tests. It should be ready to go. |
|
@mahdiboomeri Just to let you know we had to revert part of this as a hotfix owing to increased type complexity: see #1050. If you have any ideas, a PR would be most welcome 🙏 |
|
@danielroe I think moving Before: After: Is there any reproduction on this? |
|
Previously, it reproduced in the Nuxt |
🔗 Linked issue
resolves #804, resolves #1000
❓ Type of change
📚 Description
This PR transforms the output type of $Fetch to better match what JSON.stringify returns (using trpc and remix implementation).
This is potentially a breaking change.
📝 Checklist