Skip to content

fix(SelectItem): export SelectItemEmits type (#2526)#2527

Merged
zernonia merged 1 commit into
unovue:v2from
laborsync:export-select-item-emits
Mar 21, 2026
Merged

fix(SelectItem): export SelectItemEmits type (#2526)#2527
zernonia merged 1 commit into
unovue:v2from
laborsync:export-select-item-emits

Conversation

@jburgerio

@jburgerio jburgerio commented Mar 19, 2026 •
edited by coderabbitai Bot
Loading

Copy link
Copy Markdown
Contributor

Exported missing SelectItemEmits type from its Vue component for improved type safety and usage consistency.

Fixes Issue #2526

Summary by CodeRabbit

  • Chores
    • Exported additional type definitions from the Select component to improve developer experience when working with component APIs.

@coderabbitai

coderabbitai Bot commented Mar 19, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 8ab6bb5f-e2f2-44a7-8fab-1bc4c6d1a39b

📥 Commits

Reviewing files that changed from the base of the PR and between bc1db72 and 291fd87.

📒 Files selected for processing (1)
  • packages/core/src/Select/index.ts
📝 Walkthrough

Walkthrough

A single re-export of the SelectItemEmits type from SelectItem.vue is added to the Select module's public API surface, expanding the available exported types for external consumption.

Changes

Cohort / File(s) Summary
Select Module Export
packages/core/src/Select/index.ts		 Added re-export of SelectItemEmits type from ./SelectItem.vue to the public API.

Possibly related issues

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

🐰 A type hops free into the light,
SelectItemEmits now exports bright,
No magic needed, just a line so small,
The API grows, serving one and all! 🎉

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: exporting the SelectItemEmits type from SelectItem component. It is concise, specific, and clearly summarizes the primary purpose of the changeset.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
📝 Coding Plan
  • Generate coding plan for human review comments

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Tip

CodeRabbit can generate a title for your PR based on the changes.

Add @coderabbitai placeholder anywhere in the title of your PR and CodeRabbit will replace it with a title based on the changes in the PR. You can change the placeholder by changing the reviews.auto_title_placeholder setting.

@pkg-pr-new

pkg-pr-new Bot commented Mar 19, 2026

Copy link
Copy Markdown

Open in StackBlitz

npm i https://pkg.pr.new/reka-ui@2527

commit: 291fd87

@zernonia zernonia linked an issue Mar 21, 2026 that may be closed by this pull request
[Bug]: The SelectItemEmits type of SelectItem is not exported #2526
Closed
@zernonia zernonia merged commit 49d1d32 into unovue:v2 Mar 21, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Bug]: The SelectItemEmits type of SelectItem is not exported

2 participants

@jburgerio @zernonia