fix(tooltip,hovercard): close when scrollable ancestor is scrolled#2557
Merged
Conversation
Tooltip already had a window scroll listener but lacked `{ capture: true }`,
so it only fired for page-level scroll and missed scrolls on inner overflow
containers (scroll events don't bubble). HoverCard had no scroll handler at all.
Fixes #2543
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Contributor
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔗 Linked issue
Resolves #2543
❓ Type of change
📚 Description
TooltipContentandHoverCardContentdid not close when a scrollable ancestor container was scrolled — the floating element would stay open and appear visually detached from its trigger.Root cause:
scrollevents do not bubble. A listener onwindowwithout{ capture: true }only fires for page-level scroll (window/document), never for scrolls inside overflow containers.Tooltip already had a window scroll listener with the right logic (
target.contains(trigger)) — it just needed{ capture: true }to intercept scrolls from inner containers.HoverCard had no scroll handler at all — added the same pattern.
Changes:
TooltipContentImpl.vue— add{ capture: true }to the existinguseEventListenerscroll call (one-character change)HoverCardContentImpl.vue— adduseEventListener(window, 'scroll', ..., { capture: true })callingonDismiss()when the scrolled element contains the triggerNo new props, no new API surface, no dependency on
getOverflowAncestors. Thecapturephase approach catches scroll from any ancestor container without needing to enumerate them.📝 Checklist
🤖 Generated with Claude Code
Summary by CodeRabbit
New Features
Bug Fixes