packages/core/src/Toolbar/Toolbar.test.ts (1)

32-96: ⚡ Quick win

Consider adding a test for dynamic disabled state changes.

The current tests verify the static/initial disabled state, which covers the primary bug. To fully validate the reactive watcher added to RovingFocusItem, consider adding a test that:

1. Mounts a toolbar with enabled items
2. Programmatically changes items to disabled after mount
3. Verifies the toolbar root's tabindex updates to "-1" reactively

This would increase confidence that the watcher correctly handles runtime state changes.

🧪 Example test structure

it('should update tabindex reactively when items are disabled after mount', async () => {
  const TestComponent = defineComponent({
    components: { ToolbarRoot, ToolbarToggleGroup, ToolbarToggleItem },
    setup() {
      const model = ref([])
      const allDisabled = ref(false)
      return { model, allDisabled }
    },
    template: `
      <ToolbarRoot aria-label="Test toolbar">
        <ToolbarToggleGroup v-model="model" type="multiple">
          <ToolbarToggleItem value="bold" :disabled="allDisabled">Bold</ToolbarToggleItem>
        </ToolbarToggleGroup>
      </ToolbarRoot>
    `,
  })

  const wrapper = mount(TestComponent, { attachTo: document.body })
  await nextTick()
  
  const root = wrapper.find('[role="toolbar"]')
  expect(root.attributes('tabindex')).toBe('0')
  
  // Dynamically disable
  await wrapper.vm.allDisabled = true
  await nextTick()
  expect(root.attributes('tabindex')).toBe('-1')
  
  wrapper.unmount()
})

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@packages/core/src/Toolbar/Toolbar.test.ts` around lines 32 - 96, Add a new
test case after the existing tests in the describe block that validates reactive
disabled state changes. Create a TestComponent with a reactive ref (like
allDisabled) controlling the disabled property of ToolbarToggleItem, mount it
with an enabled item initially, verify the toolbar root has tabindex of '0',
then programmatically set the disabled state to true and await nextTick, and
finally verify the tabindex reactively updates to '-1' to confirm the watcher in
RovingFocusItem properly handles runtime state changes.