feat: add support for HTML search element#1828
Merged
Merged
Conversation
Collaborator
Author
|
Extended the PR by the work @EnergeticBark did in #1797. Tests pass, also when testing against both a valid and an invalid test file. @sideshowbarker, is there more to the process than filing a PR? Who could help review and give feedback? |
Added schema definitions for the `search` element, including its attributes and content model, aligning it with flow content standards. Updated the changelog to reflect the addition. Signed-off-by: Jens Oliver Meiert <jens@meiert.com> Co-authored-by: Seth Humphries <seth.humphries@live.com>
Add support for implicit 'search' ARIA attribute as both landmark and restricted role. Improve attribute structures to align better with ARIA standards and address potential accessibility use cases. Signed-off-by: Jens Oliver Meiert <jens@meiert.com>
57e76b5 to
0777a6b
Compare
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bear with me—on the deep end of the pool here. Got the validator to run locally and the proposed changes to validate the
searchelement. Could not make out any other necessary changes, but am prepared to make additional adjustments.Fixes #1569