add proposed search element#355
Merged
scottaohara merged 7 commits intogh-pagesfrom Mar 24, 2023
Merged
Conversation
The proposed `search` element would map to `role=search` in Core AAM. **TODO 1:** If a `<search>` were to contain a `<form>` element, will need to indicate to user agents that they must not expose the `<form>` as a landmark. Question: if an author has given the `<form>` an accName, ignore this rule, or, should this be used as a way to name a `<search>` in its accName calculation? **TODO 2:** Add `<search>` to accName/Description section
7 tasks
Member
Author
|
just commenting to say that the build will continue to report an error until HTML has merged the new search element. This should not block merging here, when ready to do so. |
Contributor
Member
Author
|
thank you @zcorpan |
zcorpan
approved these changes
Mar 24, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The proposed
searchelement (whatwg/html#7320) would map torole=searchin Core AAM.closes #369
Preview | Diff