Merged
Conversation
Warning message: The `for` and `dfn-for` attributes are deprecated. Please use `data-dfn-for` instead. See developer console. Specific changes: / for=/ data-dfn-for=/g / dfn-for=/ data-dfn-for=/g
markafoltz
approved these changes
Oct 24, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@mfoltzgoogle, I noticed ReSpec logs the following console warnings:
(Since these warnings were not surfaced through the ReSpec UI, I missed them in my initial patch 35f4aa9)
This PR fixes these remaining warnings in commit bcdd827
In a separate commit 7bd0067 I tidied the source to bring the more recent changes in line with the conventions.
All changes are purely editorial and under the hood, no changes to the rendered output.
Preview | Diff