Add Windows PowerShell hook commands#2
Open
AndreKalberer wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
commandWindowsoverrides so Codex uses PowerShell hook entrypoints on Windows instead of invoking.shfiles directly.Linked Issue
Closes warpdotdev/warp#13391
Manual Windows Evidence
Before - upstream
mainuses.shhook commands on WindowsTested against upstream
mainatf11334d. Installingwarp@codex-warpand running the Codex hook smoke test causes Windows to show the app-selection dialog for opening a.shfile.before-sh-dialog-compressed.mp4
After - this PR uses PowerShell hook commands on Windows
Tested against this PR at
5c01e7c. Installingwarp@codex-warpfrom the patched branch and running the same Codex hook smoke test completes without the.shapp-selection dialog. The visible hook log showsSessionStart,UserPromptSubmit, andStopcompleting.after-powershell-hooks-compressed.mp4
Testing
Get-ChildItem -Recurse -Filter *.ps1 | ForEach-Object { ... [System.Management.Automation.Language.Parser]::ParseFile(...) ... }Get-Content -Raw plugins/warp/hooks/hooks.json | ConvertFrom-Json; Get-Content -Raw plugins/orchestration/hooks/hooks.json | ConvertFrom-JsonC:\Program Files\Git\bin\bash.exe tests/test-hooks.shon-session-start.ps1+ cleanup throughon-session-end.ps1warp@codex-warpfrom upstreammain(f11334d) and this PR branch (5c01e7c)