chore: remove pnpm dedupe check from CI and lint-staged #1429
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Important Installation incomplete: to start using Gemini Code Assist, please ask the organization owner(s) to visit the Gemini Code Assist Admin Console and sign the Terms of Services. |
✅ Deploy Preview for rslib ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes the pnpm dedupe --check validation from both the CI workflow and pre-commit hooks to stop enforcing strict dependency deduplication checks.
Key Changes:
- Removed the "Check pnpm Dedupe" step from the CI lint workflow
- Removed the
pnpm-lock.yamllint-staged hook that ranpnpm dedupe --check
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
.github/workflows/lint.yml |
Removed the dedupe check step from the CI workflow, including the conditional logic for release branches |
package.json |
Removed the pnpm-lock.yaml entry from the nano-staged configuration that triggered dedupe checks on lockfile changes |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
fi3ework
approved these changes
Jan 5, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Removes the
pnpm dedupe --checkstep from the CI workflow (lint.yml) andlint-stagedconfiguration inpackage.jsonto disable unexpected deduplication checks.https://github.com/web-infra-dev/rslib/actions/runs/20615576433/job/59207588462
pnpm dedupe will be executed when renovate bump deps now.
Related Links
Checklist