feat(core): improve build status logging in watch mode #1437
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR improves the build status logging in watch mode by checking for compilation errors before logging the success message. When errors are present, it now logs an error message instead of a misleading success message.
- Added error detection logic to the
onAfterBuildhook usingstats?.hasErrors() - Changed log level from
successtoerrorwhen build errors occur - Updated message consistency (changed "build complete" to "build completed")
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
chenjiahan
approved these changes
Jan 8, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Update
onAfterBuildhook increateRslibto check for compilation errors before logging the success message in watch mode of fist compile.If errors exist, log an error message instead to avoid misleading "build complete" status when errors occurred.
before
after
Related Links
Checklist