refactor: change dependencies_diagnostics_artifact to use atomic_refcell (#12415)

hardfist · cursoragent · web-flow · commit a9e97cadd9df · 2025-12-11T11:21:00.000+08:00
Refactor: Use Arc&lt;AtomicRefCell&gt; for dependencies_diagnostics_artifact

Co-authored-by: Cursor Agent &lt;cursoragent@cursor.com&gt;
diff --git a/crates/rspack_core/src/compilation/mod.rs b/crates/rspack_core/src/compilation/mod.rs
@@ -250,7 +250,7 @@ pub struct Compilation {
   // artifact for infer_async_modules_plugin
   pub async_modules_artifact: Arc<AtomicRefCell<AsyncModulesArtifact>>,
   // artifact for collect_dependencies_diagnostics
-  pub dependencies_diagnostics_artifact: DerefOption<DependenciesDiagnosticsArtifact>,
+  pub dependencies_diagnostics_artifact: Arc<AtomicRefCell<DependenciesDiagnosticsArtifact>>,
   // artifact for side_effects_flag_plugin
   pub side_effects_optimize_artifact: DerefOption<SideEffectsOptimizeArtifact>,
   // artifact for module_ids
@@ -389,9 +389,9 @@ impl Compilation {
 
       async_modules_artifact: Arc::new(AtomicRefCell::new(AsyncModulesArtifact::default())),
       imported_by_defer_modules_artifact: Default::default(),
-      dependencies_diagnostics_artifact: DerefOption::new(
+      dependencies_diagnostics_artifact: Arc::new(AtomicRefCell::new(
         DependenciesDiagnosticsArtifact::default(),
-      ),
+      )),
       side_effects_optimize_artifact: DerefOption::new(Default::default()),
       module_ids_artifact: Default::default(),
       named_chunk_ids_artifact: Default::default(),
diff --git a/crates/rspack_core/src/compiler/mod.rs b/crates/rspack_core/src/compiler/mod.rs
@@ -1,8 +1,5 @@
 mod rebuild;
-use std::{
-  mem,
-  sync::{Arc, atomic::AtomicU32},
-};
+use std::sync::{Arc, atomic::AtomicU32};
 
 use futures::future::join_all;
 use rspack_error::Result;
@@ -323,18 +320,17 @@ impl Compiler {
       wait_for_signal("seal compilation");
     }
     self.build_module_graph().await?;
-    let mut dependencies_diagnostics_artifact =
-      mem::take(&mut self.compilation.dependencies_diagnostics_artifact);
+    let dependencies_diagnostics_artifact =
+      self.compilation.dependencies_diagnostics_artifact.clone();
     let async_modules_artifact = self.compilation.async_modules_artifact.clone();
     let diagnostics = self
       .compilation
       .collect_build_module_graph_effects(
-        &mut dependencies_diagnostics_artifact,
+        &mut dependencies_diagnostics_artifact.borrow_mut(),
         &mut async_modules_artifact.borrow_mut(),
       )
       .await?;
     self.compilation.extend_diagnostics(diagnostics);
-    self.compilation.dependencies_diagnostics_artifact = dependencies_diagnostics_artifact;
     self.compilation.seal(self.plugin_driver.clone()).await?;
     logger.time_end(start);
 
