perf(rstest): minor performance optimization (#12469)

fi3ework · web-flow · commit ec646ebb8370 · 2025-12-17T10:44:03.000+08:00
* perf(rstest): minor performance optimization

* revert regex
diff --git a/crates/rspack_plugin_rstest/src/parser_plugin.rs b/crates/rspack_plugin_rstest/src/parser_plugin.rs
@@ -183,14 +183,9 @@ impl RstestParserPlugin {
 
   fn calc_mocked_target(&self, value: &str) -> Utf8PathBuf {
     // node:foo will be mocked to `__mocks__/foo`.
-    let path_buf = Utf8PathBuf::from(
-      value
-        .to_string()
-        .strip_prefix("node:")
-        .unwrap_or(value.as_ref())
-        .to_string(),
-    );
-    let is_relative_request = path_buf.to_string().starts_with("."); // TODO: consider alias?
+    let stripped = value.strip_prefix("node:").unwrap_or(value);
+    let path_buf = Utf8PathBuf::from(stripped);
+    let is_relative_request = stripped.starts_with('.'); // TODO: consider alias?
 
     if is_relative_request {
       // Mock relative request to alongside `__mocks__` directory.
diff --git a/crates/rspack_plugin_rstest/src/plugin.rs b/crates/rspack_plugin_rstest/src/plugin.rs
@@ -163,13 +163,14 @@ struct MockFlagPos {
 
 #[plugin_hook(CompilationProcessAssets for RstestPlugin, stage = Compilation::PROCESS_ASSETS_STAGE_ADDITIONAL)]
 async fn mock_hoist_process_assets(&self, compilation: &mut Compilation) -> Result<()> {
-  let mut files = vec![];
+  let mut files = Vec::with_capacity(compilation.chunk_by_ukey.len());
 
   for chunk in compilation.chunk_by_ukey.values() {
     for file in chunk.files() {
       files.push(file.clone());
     }
   }
+
   let regex = regex::Regex::new(r"\/\* RSTEST:(MOCK|UNMOCK|MOCKREQUIRE|HOISTED)_(.*?):(.*?) \*\/")
     .expect("should initialize `Regex`");
 

Original file line number	Diff line number	Diff line change
`@@ -163,13 +163,14 @@ struct MockFlagPos {`
`163`	`163`
`164`	`164`	`#[plugin_hook(CompilationProcessAssets for RstestPlugin, stage = Compilation::PROCESS_ASSETS_STAGE_ADDITIONAL)]`
`165`	`165`	`async fn mock_hoist_process_assets(&self, compilation: &mut Compilation) -> Result<()> {`
`166`		`- let mut files = vec![];`
	`166`	`+ let mut files = Vec::with_capacity(compilation.chunk_by_ukey.len());`
`167`	`167`
`168`	`168`	`for chunk in compilation.chunk_by_ukey.values() {`
`169`	`169`	`for file in chunk.files() {`
`170`	`170`	`files.push(file.clone());`
`171`	`171`	`}`
`172`	`172`	`}`
	`173`	`+`
`173`	`174`	`let regex = regex::Regex::new(r"\/\* RSTEST:(MOCK\|UNMOCK\|MOCKREQUIRE\|HOISTED)_(.?):(.?) \*\/")`
`174`	`175`	.expect("should initialize `Regex`");
`175`	`176`