Skip to content

docs: fix rules[].use example #12466

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
chenjiahan merged 1 commit into from
Dec 16, 2025
Merged

docs: fix rules[].use example #12466

chenjiahan merged 1 commit into from
Dec 16, 2025

Conversation

@henryqdineen
Copy link
Contributor

@henryqdineen henryqdineen commented Dec 16, 2025

Summary

  type RuleSetUse =
    | RuleSetUseItem[]
    | RuleSetUseItem
    | ((ctx: RawFuncUseCtx) => RuleSetUseItem[]);

When use is used as a function it should return RuleSetUseItem[] (an array), not a single RuleSetUseItem. My understanding, at least with webpack is that each item in the array is expected to have an ident set but even webpack does not document that well.

Thanks!

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@netlify
Copy link

netlify bot commented Dec 16, 2025 •
edited
Loading

✅ Deploy Preview for rspack ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit de6a843
🔍 Latest deploy log https://app.netlify.com/projects/rspack/deploys/6940ff7c6f55f60008158175
😎 Deploy Preview https://deploy-preview-12466--rspack.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@github-actions github-actions bot added the release: document release: document related release(mr only) label Dec 16, 2025
chenjiahan
chenjiahan approved these changes Dec 16, 2025
View reviewed changes
Copy link
Member

@chenjiahan chenjiahan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@chenjiahan chenjiahan merged commit 726679b into web-infra-dev:main Dec 16, 2025
29 checks passed
@CPunisher CPunisher mentioned this pull request Dec 17, 2025
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chenjiahan chenjiahan chenjiahan approved these changes

Assignees

No one assigned

Labels

release: document release: document related release(mr only)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@henryqdineen @chenjiahan