docs: remove unused code, correct the usage of Link and Table. #12498
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for rspack ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors the codebase to standardize link handling and table rendering by replacing custom implementations with Rspress's built-in components.
- Removes custom table component wrappers (Table, Tr, Td, Th) and their associated CSS styling
- Replaces all
<a>tags with Rspress'sLinkcomponent for consistent navigation behavior - Updates the Table component to use Rspress's default MDX table component via
getCustomMDXComponent()
Reviewed changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| website/theme/index.css | Removes unused CSS styling for table links |
| website/components/builtIns/mdx-components.tsx | Deletes entire file containing custom table component wrappers |
| website/components/builtIns/Table.tsx | Refactors to use Rspress's MDX table component and adds Link override for markdown links |
| website/components/WebpackLicense.tsx | Replaces <a> tags with Link component |
| website/components/RandomMemberList.tsx | Replaces <a> tags with Link component, removes manual target and rel attributes |
| website/components/PropertyType.tsx | Replaces <a> tag with Link component for internal navigation |
| website/components/PluginSupportStatusTable.tsx | Simplifies link rendering by using Link component |
| website/components/DeprecationTable.tsx | Replaces <a> tags with Link component for internal documentation links |
| website/components/CommunityCompatibleTable.tsx | Simplifies external link rendering with Link component |
| website/components/ApiMeta.tsx | Replaces <a> tags with Link component for version links |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
docs: remove unused code
correct the usage of Link and Table
Link: In basically all cases, we should use Link instead of using <a> to prevent page refreshes during navigation and automatically set
target="_blank" rel="noreferrerwhen visiting trailing pages.Table: Completely use Rspress's default table, so remove
unnecessary code
Related links
Checklist