Skip to content

refactor: use EsmLibraryPlugin for modern-module library type #12712

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
JSerFeng merged 1 commit into from
Jan 20, 2026
Merged

refactor: use EsmLibraryPlugin for modern-module library type #12712

JSerFeng merged 1 commit into from
Jan 20, 2026

Conversation

@JSerFeng
Copy link
Contributor

@JSerFeng JSerFeng commented Jan 13, 2026 •
edited
Loading

Summary

Refactor: Using EsmLibraryPlugin as the implementation of modern-module.

Update a lots of incorrect test.config.js.

Introduce a new config in library preserveModules which only works for modern-module at present

Related links

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@github-actions github-actions bot added release: refactor team The issue/pr is created by the member of Rspack. labels Jan 13, 2026
@netlify
Copy link

netlify bot commented Jan 13, 2026 •
edited
Loading

✅ Deploy Preview for rspack-v2 canceled.

Name Link
🔨 Latest commit 36c87b9
🔍 Latest deploy log https://app.netlify.com/projects/rspack-v2/deploys/696f258b76740800085a6b87

@JSerFeng JSerFeng force-pushed the refactor/esm-library branch from ff796d4 to ac31718 Compare January 13, 2026 07:05
@github-actions
Copy link
Contributor

github-actions bot commented Jan 13, 2026 •
edited
Loading

Rsdoctor Bundle Diff Analysis

Found 5 projects in monorepo, 5 projects with changes.

📊 Quick Summary
Project Total Size Change
react-10k 5.7 MB -
react-1k 825.3 KB -
react-5k 2.7 MB -
ui-components 2.1 MB -
rome 985.8 KB -
📋 Detailed Reports (Click to expand)

📁 react-10k

Path: ../build-tools-performance/cases/react-10k/dist/rsdoctor-data.json

⚠️ No baseline data found - Unable to perform comparison analysis

Metric Current Baseline Change
📊 Total Size 5.7 MB - -
📄 JavaScript 5.7 MB - -
🎨 CSS 21.0 B - -
🌐 HTML 0 B - -
📁 Other Assets 0 B - -

📁 react-1k

Path: ../build-tools-performance/cases/react-1k/dist/rsdoctor-data.json

⚠️ No baseline data found - Unable to perform comparison analysis

Metric Current Baseline Change
📊 Total Size 825.3 KB - -
📄 JavaScript 825.3 KB - -
🎨 CSS 0 B - -
🌐 HTML 0 B - -
📁 Other Assets 0 B - -

📁 react-5k

Path: ../build-tools-performance/cases/react-5k/dist/rsdoctor-data.json

⚠️ No baseline data found - Unable to perform comparison analysis

Metric Current Baseline Change
📊 Total Size 2.7 MB - -
📄 JavaScript 2.7 MB - -
🎨 CSS 21.0 B - -
🌐 HTML 0 B - -
📁 Other Assets 0 B - -

📁 ui-components

Path: ../build-tools-performance/cases/ui-components/dist/rsdoctor-data.json

⚠️ No baseline data found - Unable to perform comparison analysis

Metric Current Baseline Change
📊 Total Size 2.1 MB - -
📄 JavaScript 2.0 MB - -
🎨 CSS 83.0 KB - -
🌐 HTML 0 B - -
📁 Other Assets 0 B - -

📁 rome

Path: ../build-tools-performance/cases/rome/dist/rsdoctor-data.json

⚠️ No baseline data found - Unable to perform comparison analysis

Metric Current Baseline Change
📊 Total Size 985.8 KB - -
📄 JavaScript 985.8 KB - -
🎨 CSS 0 B - -
🌐 HTML 0 B - -
📁 Other Assets 0 B - -

Generated by Rsdoctor GitHub Action

@github-actions
Copy link
Contributor

github-actions bot commented Jan 13, 2026 •
edited
Loading

📦 Binary Size-limit

Comparing 36c87b9 to fix: sort css by sourceorder, esm import comes first (#12778) by Fy

🎉 Size decreased by 319.50KB from 47.99MB to 47.68MB (⬇️0.65%)

@codspeed-hq
Copy link

codspeed-hq bot commented Jan 13, 2026 •
edited
Loading

CodSpeed Performance Report

Merging this PR will improve performance by 10.08%

Comparing refactor/esm-library (36c87b9) with v2 (a345710)

Summary

⚡ 1 improved benchmark
✅ 15 untouched benchmarks
⏩ 1 skipped benchmark1

Performance Changes

Benchmark BASE HEAD Efficiency
⚡ bundle@threejs-development 797.8 ms 724.7 ms +10.08%

Footnotes

  1. 1 benchmark was skipped, so the baseline result was used instead. If it was deleted from the codebase, click here and archive it to remove it from the performance reports. ↩

@JSerFeng JSerFeng force-pushed the refactor/esm-library branch from ac31718 to e54fb05 Compare January 13, 2026 07:40
@JSerFeng JSerFeng force-pushed the refactor/esm-library branch 3 times, most recently from 86db9f7 to e2061a6 Compare January 20, 2026 03:56
@JSerFeng JSerFeng force-pushed the refactor/esm-library branch from e2061a6 to 36c87b9 Compare January 20, 2026 06:49
@JSerFeng JSerFeng enabled auto-merge (squash) January 20, 2026 08:02
@JSerFeng JSerFeng merged commit 861fe4f into v2 Jan 20, 2026
78 of 80 checks passed
@JSerFeng JSerFeng deleted the refactor/esm-library branch January 20, 2026 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@LingyuCoder LingyuCoder LingyuCoder approved these changes

@hardfist hardfist Awaiting requested review from hardfist hardfist is a code owner

@jerrykingxyz jerrykingxyz Awaiting requested review from jerrykingxyz

@h-a-n-a h-a-n-a Awaiting requested review from h-a-n-a

Assignees

No one assigned

Labels

release: refactor team The issue/pr is created by the member of Rspack.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@JSerFeng @LingyuCoder