Skip to content

refactor!: drop support for Node 18 #12739

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
chenjiahan merged 2 commits into from
Jan 15, 2026
Merged

refactor!: drop support for Node 18 #12739

chenjiahan merged 2 commits into from
Jan 15, 2026

Conversation

@Timeless0911
Copy link
Contributor

@Timeless0911 Timeless0911 commented Jan 15, 2026

Summary

As Node.js 18 reached its end-of-life on April 30, 2025, Rspack 2.0 will no longer support this version. The minimum supported version will be Node.js 20.19.

Related links

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@netlify
Copy link

netlify bot commented Jan 15, 2026 •
edited
Loading

✅ Deploy Preview for rspack-v2 ready!

Name Link
🔨 Latest commit 44dad94
🔍 Latest deploy log https://app.netlify.com/projects/rspack-v2/deploys/6968a4320fc56a0008e0e4dc
😎 Deploy Preview https://deploy-preview-12739--rspack-v2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@github-actions github-actions bot added release: refactor team The issue/pr is created by the member of Rspack. labels Jan 15, 2026
@github-actions
Copy link
Contributor

github-actions bot commented Jan 15, 2026 •
edited
Loading

Rsdoctor Bundle Diff Analysis

Found 5 projects in monorepo, 3 projects with changes.

📊 Quick Summary
Project Total Size Change
react-10k 5.7 MB -8.0 B (-0.0%)
react-1k 825.4 KB 0
react-5k 2.7 MB +1.0 B (0.0%)
rome 986.0 KB +1.7 KB (0.2%)
ui-components 2.1 MB 0
📋 Detailed Reports (Click to expand)

📁 react-10k

Path: ../build-tools-performance/cases/react-10k/dist/rsdoctor-data.json

📌 Baseline Commit: 0eb2ee3d8b | PR: #12742

Metric Current Baseline Change
📊 Total Size 5.7 MB 5.7 MB -8.0 B (-0.0%)
📄 JavaScript 5.7 MB 5.7 MB -8.0 B (-0.0%)
🎨 CSS 21.0 B 21.0 B 0
🌐 HTML 0 B 0 B 0
📁 Other Assets 0 B 0 B 0

📦 Download Diff Report: react-10k Bundle Diff

📁 react-5k

Path: ../build-tools-performance/cases/react-5k/dist/rsdoctor-data.json

📌 Baseline Commit: 0eb2ee3d8b | PR: #12742

Metric Current Baseline Change
📊 Total Size 2.7 MB 2.7 MB +1.0 B (0.0%)
📄 JavaScript 2.7 MB 2.7 MB +1.0 B (0.0%)
🎨 CSS 21.0 B 21.0 B 0
🌐 HTML 0 B 0 B 0
📁 Other Assets 0 B 0 B 0

📦 Download Diff Report: react-5k Bundle Diff

📁 rome

Path: ../build-tools-performance/cases/rome/dist/rsdoctor-data.json

📌 Baseline Commit: 0eb2ee3d8b | PR: #12742

Metric Current Baseline Change
📊 Total Size 986.0 KB 984.3 KB +1.7 KB (0.2%)
📄 JavaScript 986.0 KB 984.3 KB +1.7 KB (0.2%)
🎨 CSS 0 B 0 B 0
🌐 HTML 0 B 0 B 0
📁 Other Assets 0 B 0 B 0

📦 Download Diff Report: rome Bundle Diff

Generated by Rsdoctor GitHub Action

@github-actions
Copy link
Contributor

github-actions bot commented Jan 15, 2026 •
edited
Loading

📦 Binary Size-limit

Comparing 44dad94 to refactor: move logger into pass and reorg some passes (#12742) by hardfist

🎉 Size decreased by 471.25KB from 48.03MB to 47.57MB (⬇️0.96%)

@codspeed-hq
Copy link

codspeed-hq bot commented Jan 15, 2026 •
edited
Loading

Merging this PR will not alter performance

✅ 16 untouched benchmarks
⏩ 1 skipped benchmark1

Comparing drop-node-18 (44dad94) with v2 (b07e854)

Open in CodSpeed

Footnotes

  1. 1 benchmark was skipped, so the baseline result was used instead. If it was deleted from the codebase, click here and archive it to remove it from the performance reports. ↩

chenjiahan
chenjiahan reviewed Jan 15, 2026
View reviewed changes
chenjiahan
chenjiahan reviewed Jan 15, 2026
View reviewed changes
chenjiahan
chenjiahan reviewed Jan 15, 2026
View reviewed changes
Copy link
Member

@chenjiahan chenjiahan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we enable this test case: #7644

@chenjiahan chenjiahan enabled auto-merge (squash) January 15, 2026 08:26
@chenjiahan chenjiahan merged commit 9fca97e into v2 Jan 15, 2026
53 checks passed
@chenjiahan chenjiahan deleted the drop-node-18 branch January 15, 2026 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@stormslowly stormslowly stormslowly approved these changes

@LingyuCoder LingyuCoder LingyuCoder approved these changes

@chenjiahan chenjiahan chenjiahan approved these changes

@hardfist hardfist Awaiting requested review from hardfist hardfist is a code owner

Assignees

No one assigned

Labels

release: refactor team The issue/pr is created by the member of Rspack.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@Timeless0911 @stormslowly @LingyuCoder @chenjiahan