Skip to content

feat!: remove deprecated draft option from LightningCSS minimizer #12740

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
LingyuCoder merged 1 commit into from
Jan 15, 2026
Merged

feat!: remove deprecated draft option from LightningCSS minimizer #12740

LingyuCoder merged 1 commit into from
Jan 15, 2026

Conversation

@LingyuCoder
Copy link
Contributor

@LingyuCoder LingyuCoder commented Jan 15, 2026

Summary

This PR removes the deprecated draft option from the LightningCSS minimizer plugin. The option was previously marked as deprecated in favor of drafts, and this change completes the deprecation cycle by removing the old option entirely. Users should now use the drafts option instead.

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@netlify
Copy link

netlify bot commented Jan 15, 2026 •
edited
Loading

✅ Deploy Preview for rspack-v2 ready!

Name Link
🔨 Latest commit 085afb1
🔍 Latest deploy log https://app.netlify.com/projects/rspack-v2/deploys/69687e19e836e400071e3477
😎 Deploy Preview https://deploy-preview-12740--rspack-v2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@github-actions github-actions bot added the team The issue/pr is created by the member of Rspack. label Jan 15, 2026
@LingyuCoder LingyuCoder changed the title chore: remove deprecated draft option from LightningCSS minimizer feat!: remove deprecated draft option from LightningCSS minimizer Jan 15, 2026
@github-actions github-actions bot added the release: feature release: feature related release(mr only) label Jan 15, 2026
@LingyuCoder LingyuCoder added release: breaking change release: breaking change related release(mr only) and removed release: feature release: feature related release(mr only) labels Jan 15, 2026
@github-actions
Copy link
Contributor

github-actions bot commented Jan 15, 2026 •
edited
Loading

Rsdoctor Bundle Diff Analysis

Found 5 projects in monorepo, 3 projects with changes.

📊 Quick Summary
Project Total Size Change
react-10k 5.7 MB -8.0 B (-0.0%)
react-1k 825.4 KB 0
react-5k 2.7 MB +1.0 B (0.0%)
rome 986.0 KB +1.7 KB (0.2%)
ui-components 2.1 MB 0
📋 Detailed Reports (Click to expand)

📁 react-10k

Path: ../build-tools-performance/cases/react-10k/dist/rsdoctor-data.json

📌 Baseline Commit: ad662bcbaf | PR: #12678

Metric Current Baseline Change
📊 Total Size 5.7 MB 5.7 MB -8.0 B (-0.0%)
📄 JavaScript 5.7 MB 5.7 MB -8.0 B (-0.0%)
🎨 CSS 21.0 B 21.0 B 0
🌐 HTML 0 B 0 B 0
📁 Other Assets 0 B 0 B 0

📦 Download Diff Report: react-10k Bundle Diff

📁 react-5k

Path: ../build-tools-performance/cases/react-5k/dist/rsdoctor-data.json

📌 Baseline Commit: ad662bcbaf | PR: #12678

Metric Current Baseline Change
📊 Total Size 2.7 MB 2.7 MB +1.0 B (0.0%)
📄 JavaScript 2.7 MB 2.7 MB +1.0 B (0.0%)
🎨 CSS 21.0 B 21.0 B 0
🌐 HTML 0 B 0 B 0
📁 Other Assets 0 B 0 B 0

📦 Download Diff Report: react-5k Bundle Diff

📁 rome

Path: ../build-tools-performance/cases/rome/dist/rsdoctor-data.json

📌 Baseline Commit: ad662bcbaf | PR: #12678

Metric Current Baseline Change
📊 Total Size 986.0 KB 984.3 KB +1.7 KB (0.2%)
📄 JavaScript 986.0 KB 984.3 KB +1.7 KB (0.2%)
🎨 CSS 0 B 0 B 0
🌐 HTML 0 B 0 B 0
📁 Other Assets 0 B 0 B 0

📦 Download Diff Report: rome Bundle Diff

Generated by Rsdoctor GitHub Action

@github-actions
Copy link
Contributor

github-actions bot commented Jan 15, 2026 •
edited
Loading

📦 Binary Size-limit

Comparing 085afb1 to refactor: move pass into separate folder and driven by run_passes (#12735) by hardfist

🎉 Size decreased by 452.25KB from 48.01MB to 47.57MB (⬇️0.92%)

@codspeed-hq
Copy link

codspeed-hq bot commented Jan 15, 2026 •
edited
Loading

CodSpeed Performance Report

Merging this PR will not alter performance

Comparing chore/remove-deprecated-draft-option (085afb1) with v2 (3c5a3e0)

Summary

✅ 16 untouched benchmarks
⏩ 1 skipped benchmark1

Footnotes

  1. 1 benchmark was skipped, so the baseline result was used instead. If it was deleted from the codebase, click here and archive it to remove it from the performance reports. ↩

@LingyuCoder LingyuCoder enabled auto-merge (squash) January 15, 2026 05:39
@LingyuCoder LingyuCoder force-pushed the chore/remove-deprecated-draft-option branch from 3d63106 to 085afb1 Compare January 15, 2026 05:41
@LingyuCoder LingyuCoder merged commit 90611e5 into v2 Jan 15, 2026
53 checks passed
@LingyuCoder LingyuCoder deleted the chore/remove-deprecated-draft-option branch January 15, 2026 06:02
@chenjiahan chenjiahan mentioned this pull request Jan 17, 2026
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JSerFeng JSerFeng JSerFeng approved these changes

@hardfist hardfist Awaiting requested review from hardfist hardfist is a code owner

Assignees

No one assigned

Labels

release: breaking change release: breaking change related release(mr only) team The issue/pr is created by the member of Rspack.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@LingyuCoder @JSerFeng