Skip to content

fix: correct watchpack require path #12771

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
chenjiahan merged 1 commit into from
Jan 19, 2026
Merged

fix: correct watchpack require path #12771

chenjiahan merged 1 commit into from
Jan 19, 2026

Conversation

@chenjiahan
Copy link
Member

@chenjiahan chenjiahan commented Jan 17, 2026

Summary

Updated the import path for watchpack to use the compiled version from ../compiled/watchpack/index.js instead of requiring it directly by package name.

Screenshot 2026-01-17 at 21 03 35

Related links

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@chenjiahan chenjiahan requested a review from hardfist as a code owner January 17, 2026 13:11
Copilot AI review requested due to automatic review settings January 17, 2026 13:11
@netlify
Copy link

netlify bot commented Jan 17, 2026 •
edited
Loading

✅ Deploy Preview for rspack-v2 canceled.

Name Link
🔨 Latest commit 8532a81
🔍 Latest deploy log https://app.netlify.com/projects/rspack-v2/deploys/696b8a8af6d8ba0008dcab52

@github-actions github-actions bot added team The issue/pr is created by the member of Rspack. release: bug fix release: bug related release(mr only) labels Jan 17, 2026
Copilot AI reviewed Jan 17, 2026
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the watchpack dependency loading in NodeWatchFileSystem to use the pre-compiled version instead of requiring it directly by package name.

Changes:

  • Modified the require statement for watchpack to use the compiled version from ../compiled/watchpack/index.js

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@github-actions
Copy link
Contributor

github-actions bot commented Jan 17, 2026

Rsdoctor Bundle Diff Analysis

Found 5 projects in monorepo, 5 projects with changes.

📊 Quick Summary
Project Total Size Change
react-10k 5.7 MB -
react-1k 825.3 KB -
react-5k 2.7 MB -
ui-components 2.1 MB -
rome 985.8 KB -
📋 Detailed Reports (Click to expand)

📁 react-10k

Path: ../build-tools-performance/cases/react-10k/dist/rsdoctor-data.json

⚠️ No baseline data found - Unable to perform comparison analysis

Metric Current Baseline Change
📊 Total Size 5.7 MB - -
📄 JavaScript 5.7 MB - -
🎨 CSS 21.0 B - -
🌐 HTML 0 B - -
📁 Other Assets 0 B - -

📁 react-1k

Path: ../build-tools-performance/cases/react-1k/dist/rsdoctor-data.json

⚠️ No baseline data found - Unable to perform comparison analysis

Metric Current Baseline Change
📊 Total Size 825.3 KB - -
📄 JavaScript 825.3 KB - -
🎨 CSS 0 B - -
🌐 HTML 0 B - -
📁 Other Assets 0 B - -

📁 react-5k

Path: ../build-tools-performance/cases/react-5k/dist/rsdoctor-data.json

⚠️ No baseline data found - Unable to perform comparison analysis

Metric Current Baseline Change
📊 Total Size 2.7 MB - -
📄 JavaScript 2.7 MB - -
🎨 CSS 21.0 B - -
🌐 HTML 0 B - -
📁 Other Assets 0 B - -

📁 ui-components

Path: ../build-tools-performance/cases/ui-components/dist/rsdoctor-data.json

⚠️ No baseline data found - Unable to perform comparison analysis

Metric Current Baseline Change
📊 Total Size 2.1 MB - -
📄 JavaScript 2.0 MB - -
🎨 CSS 83.0 KB - -
🌐 HTML 0 B - -
📁 Other Assets 0 B - -

📁 rome

Path: ../build-tools-performance/cases/rome/dist/rsdoctor-data.json

⚠️ No baseline data found - Unable to perform comparison analysis

Metric Current Baseline Change
📊 Total Size 985.8 KB - -
📄 JavaScript 985.8 KB - -
🎨 CSS 0 B - -
🌐 HTML 0 B - -
📁 Other Assets 0 B - -

Generated by Rsdoctor GitHub Action

@github-actions
Copy link
Contributor

github-actions bot commented Jan 17, 2026

📦 Binary Size-limit

Comparing 8532a81 to chore: limit threads for codspeed benchmark (#12763) by CPunisher

🎉 Size decreased by 322.75KB from 47.99MB to 47.68MB (⬇️0.66%)

@chenjiahan chenjiahan merged commit dc4ceb3 into v2 Jan 19, 2026
59 of 61 checks passed
@chenjiahan chenjiahan deleted the watchpack_require_0117 branch January 19, 2026 02:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@Timeless0911 Timeless0911 Timeless0911 approved these changes

@hardfist hardfist Awaiting requested review from hardfist hardfist is a code owner

Assignees

No one assigned

Labels

release: bug fix release: bug related release(mr only) team The issue/pr is created by the member of Rspack.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@chenjiahan @Timeless0911