Skip to content

feat!: use rspackChunk as default value of chunkLoadingGlobal #12779

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
chenjiahan merged 2 commits into from
Jan 19, 2026
Merged

feat!: use rspackChunk as default value of chunkLoadingGlobal #12779

chenjiahan merged 2 commits into from
Jan 19, 2026

Conversation

@LingyuCoder
Copy link
Contributor

@LingyuCoder LingyuCoder commented Jan 19, 2026 •
edited
Loading

Summary

This PR changes the default naming convention for global variables from webpack-style to rspack-style:

  • output.chunkLoadingGlobal: Changed default from webpackChunk + uniqueName to rspackChunk + uniqueName

This change establishes Rspack's own identity and avoids potential conflicts when webpack and Rspack bundles coexist on the same page.

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@netlify
Copy link

netlify bot commented Jan 19, 2026 •
edited
Loading

✅ Deploy Preview for rspack-v2 canceled.

Name Link
🔨 Latest commit 8a63c75
🔍 Latest deploy log https://app.netlify.com/projects/rspack-v2/deploys/696de44f866d580008cbc922

@github-actions github-actions bot added release: feature release: feature related release(mr only) team The issue/pr is created by the member of Rspack. labels Jan 19, 2026
@LingyuCoder LingyuCoder force-pushed the feat/use-rspack-global-names branch from 63ee2d3 to 23c7ced Compare January 19, 2026 07:22
@LingyuCoder LingyuCoder changed the title feat: use rspack naming for hotUpdateGlobal and chunkLoadingGlobal feat: use rspackChunk as default value of chunkLoadingGlobal Jan 19, 2026
@github-actions
Copy link
Contributor

github-actions bot commented Jan 19, 2026 •
edited
Loading

Rsdoctor Bundle Diff Analysis

Found 5 projects in monorepo, 5 projects with changes.

📊 Quick Summary
Project Total Size Change
react-10k 5.7 MB -71.0 B (-0.0%)
react-1k 825.3 KB -41.0 B (-0.0%)
react-5k 2.7 MB -60.0 B (-0.0%)
rome 985.8 KB +1.7 KB (0.2%)
ui-components 2.1 MB -30.0 B (-0.0%)
📋 Detailed Reports (Click to expand)

📁 react-10k

Path: ../build-tools-performance/cases/react-10k/dist/rsdoctor-data.json

📌 Baseline Commit: 6991b7b596 | PR: #12778

Metric Current Baseline Change
📊 Total Size 5.7 MB 5.7 MB -71.0 B (-0.0%)
📄 JavaScript 5.7 MB 5.7 MB -71.0 B (-0.0%)
🎨 CSS 21.0 B 21.0 B 0
🌐 HTML 0 B 0 B 0
📁 Other Assets 0 B 0 B 0

📦 Download Diff Report: react-10k Bundle Diff

📁 react-1k

Path: ../build-tools-performance/cases/react-1k/dist/rsdoctor-data.json

📌 Baseline Commit: 6991b7b596 | PR: #12778

Metric Current Baseline Change
📊 Total Size 825.3 KB 825.4 KB -41.0 B (-0.0%)
📄 JavaScript 825.3 KB 825.4 KB -41.0 B (-0.0%)
🎨 CSS 0 B 0 B 0
🌐 HTML 0 B 0 B 0
📁 Other Assets 0 B 0 B 0

📦 Download Diff Report: react-1k Bundle Diff

📁 react-5k

Path: ../build-tools-performance/cases/react-5k/dist/rsdoctor-data.json

📌 Baseline Commit: 6991b7b596 | PR: #12778

Metric Current Baseline Change
📊 Total Size 2.7 MB 2.7 MB -60.0 B (-0.0%)
📄 JavaScript 2.7 MB 2.7 MB -60.0 B (-0.0%)
🎨 CSS 21.0 B 21.0 B 0
🌐 HTML 0 B 0 B 0
📁 Other Assets 0 B 0 B 0

📦 Download Diff Report: react-5k Bundle Diff

📁 rome

Path: ../build-tools-performance/cases/rome/dist/rsdoctor-data.json

📌 Baseline Commit: 6991b7b596 | PR: #12778

Metric Current Baseline Change
📊 Total Size 985.8 KB 984.2 KB +1.7 KB (0.2%)
📄 JavaScript 985.8 KB 984.2 KB +1.7 KB (0.2%)
🎨 CSS 0 B 0 B 0
🌐 HTML 0 B 0 B 0
📁 Other Assets 0 B 0 B 0

📦 Download Diff Report: rome Bundle Diff

📁 ui-components

Path: ../build-tools-performance/cases/ui-components/dist/rsdoctor-data.json

📌 Baseline Commit: 6991b7b596 | PR: #12778

Metric Current Baseline Change
📊 Total Size 2.1 MB 2.1 MB -30.0 B (-0.0%)
📄 JavaScript 2.0 MB 2.0 MB -30.0 B (-0.0%)
🎨 CSS 83.0 KB 83.0 KB 0
🌐 HTML 0 B 0 B 0
📁 Other Assets 0 B 0 B 0

📦 Download Diff Report: ui-components Bundle Diff

Generated by Rsdoctor GitHub Action

@github-actions
Copy link
Contributor

github-actions bot commented Jan 19, 2026 •
edited
Loading

📦 Binary Size-limit

Comparing 8a63c75 to fix: sort css by sourceorder, esm import comes first (#12778) by Fy

🎉 Size decreased by 322.13KB from 47.99MB to 47.68MB (⬇️0.66%)

@codspeed-hq
Copy link

codspeed-hq bot commented Jan 19, 2026 •
edited
Loading

Merging this PR will not alter performance

✅ 16 untouched benchmarks
⏩ 1 skipped benchmark1

Comparing feat/use-rspack-global-names (8a63c75) with v2 (fbd5b66)

Open in CodSpeed

Footnotes

  1. 1 benchmark was skipped, so the baseline result was used instead. If it was deleted from the codebase, click here and archive it to remove it from the performance reports. ↩

@LingyuCoder LingyuCoder changed the title feat: use rspackChunk as default value of chunkLoadingGlobal feat!: use rspackChunk as default value of chunkLoadingGlobal Jan 19, 2026
@LingyuCoder LingyuCoder added the release: breaking change release: breaking change related release(mr only) label Jan 19, 2026
@chenjiahan chenjiahan merged commit f81f16e into v2 Jan 19, 2026
53 of 55 checks passed
@chenjiahan chenjiahan deleted the feat/use-rspack-global-names branch January 19, 2026 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chenjiahan chenjiahan chenjiahan approved these changes

@hardfist hardfist Awaiting requested review from hardfist hardfist is a code owner

@h-a-n-a h-a-n-a Awaiting requested review from h-a-n-a h-a-n-a is a code owner

Assignees

No one assigned

Labels

release: breaking change release: breaking change related release(mr only) release: feature release: feature related release(mr only) team The issue/pr is created by the member of Rspack.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@LingyuCoder @chenjiahan