Skip to content

feat!: default targets for loader/plugin derived by rspack target, part 2 #12780

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
chenjiahan merged 4 commits into from
Jan 20, 2026
Merged

feat!: default targets for loader/plugin derived by rspack target, part 2 #12780

chenjiahan merged 4 commits into from
Jan 20, 2026

Conversation

@ahabhgk
Copy link
Contributor

@ahabhgk ahabhgk commented Jan 19, 2026 •
edited
Loading

Summary

  1. change platforms to targets, and it's no longer a string[] (['chrome 100', 'chrome 101', 'chrome 102', ...]), it's a targets object now ({ chrome: '100', safari: '7' }) which is more compatible with other tools' targets
  2. update docs
  3. update create-rspack template

Related links

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@ahabhgk ahabhgk requested a review from chenjiahan as a code owner January 19, 2026 08:21
@netlify
Copy link

netlify bot commented Jan 19, 2026 •
edited
Loading

✅ Deploy Preview for rspack-v2 canceled.

Name Link
🔨 Latest commit f7fe05b
🔍 Latest deploy log https://app.netlify.com/projects/rspack-v2/deploys/696f2d7cc44f5d000877af83

@github-actions github-actions bot added release: document release: document related release(mr only) team The issue/pr is created by the member of Rspack. labels Jan 19, 2026
@ahabhgk ahabhgk requested a review from hardfist January 19, 2026 08:21
@github-actions
Copy link
Contributor

github-actions bot commented Jan 19, 2026 •
edited
Loading

Rsdoctor Bundle Diff Analysis

Found 5 projects in monorepo, 5 projects with changes.

📊 Quick Summary
Project Total Size Change
react-1k 825.3 KB -
react-10k 5.7 MB -
react-5k 2.7 MB -
ui-components 2.1 MB -
rome 985.8 KB -
📋 Detailed Reports (Click to expand)

📁 react-1k

Path: ../build-tools-performance/cases/react-1k/dist/rsdoctor-data.json

⚠️ No baseline data found - Unable to perform comparison analysis

Metric Current Baseline Change
📊 Total Size 825.3 KB - -
📄 JavaScript 825.3 KB - -
🎨 CSS 0 B - -
🌐 HTML 0 B - -
📁 Other Assets 0 B - -

📁 react-10k

Path: ../build-tools-performance/cases/react-10k/dist/rsdoctor-data.json

⚠️ No baseline data found - Unable to perform comparison analysis

Metric Current Baseline Change
📊 Total Size 5.7 MB - -
📄 JavaScript 5.7 MB - -
🎨 CSS 21.0 B - -
🌐 HTML 0 B - -
📁 Other Assets 0 B - -

📁 react-5k

Path: ../build-tools-performance/cases/react-5k/dist/rsdoctor-data.json

⚠️ No baseline data found - Unable to perform comparison analysis

Metric Current Baseline Change
📊 Total Size 2.7 MB - -
📄 JavaScript 2.7 MB - -
🎨 CSS 21.0 B - -
🌐 HTML 0 B - -
📁 Other Assets 0 B - -

📁 ui-components

Path: ../build-tools-performance/cases/ui-components/dist/rsdoctor-data.json

⚠️ No baseline data found - Unable to perform comparison analysis

Metric Current Baseline Change
📊 Total Size 2.1 MB - -
📄 JavaScript 2.0 MB - -
🎨 CSS 83.0 KB - -
🌐 HTML 0 B - -
📁 Other Assets 0 B - -

📁 rome

Path: ../build-tools-performance/cases/rome/dist/rsdoctor-data.json

⚠️ No baseline data found - Unable to perform comparison analysis

Metric Current Baseline Change
📊 Total Size 985.8 KB - -
📄 JavaScript 985.8 KB - -
🎨 CSS 0 B - -
🌐 HTML 0 B - -
📁 Other Assets 0 B - -

Generated by Rsdoctor GitHub Action

@github-actions
Copy link
Contributor

github-actions bot commented Jan 19, 2026 •
edited
Loading

📦 Binary Size-limit

Comparing f7fe05b to fix: sort css by sourceorder, esm import comes first (#12778) by Fy

🎉 Size decreased by 322.13KB from 47.99MB to 47.68MB (⬇️0.66%)

@codspeed-hq
Copy link

codspeed-hq bot commented Jan 19, 2026 •
edited
Loading

CodSpeed Performance Report

Merging this PR will not alter performance

Comparing default-target-docs (f7fe05b) with v2 (a345710)

Summary

✅ 16 untouched benchmarks
⏩ 1 skipped benchmark1

Footnotes

  1. 1 benchmark was skipped, so the baseline result was used instead. If it was deleted from the codebase, click here and archive it to remove it from the performance reports. ↩

chenjiahan
chenjiahan reviewed Jan 19, 2026
View reviewed changes
@ahabhgk ahabhgk force-pushed the default-target-docs branch from 01c518c to e1da2fb Compare January 19, 2026 12:40
@ahabhgk ahabhgk changed the title docs!: default targets for loader/plugin derived by rspack target feat!: default targets for loader/plugin derived by rspack target, part 2 Jan 19, 2026
@github-actions github-actions bot added release: feature release: feature related release(mr only) and removed release: document release: document related release(mr only) labels Jan 19, 2026
@ahabhgk ahabhgk requested a review from chenjiahan January 20, 2026 07:03
@chenjiahan chenjiahan enabled auto-merge January 20, 2026 07:39
@chenjiahan chenjiahan merged commit 5ecd47e into v2 Jan 20, 2026
102 of 107 checks passed
@chenjiahan chenjiahan deleted the default-target-docs branch January 20, 2026 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chenjiahan chenjiahan chenjiahan approved these changes

@hardfist hardfist Awaiting requested review from hardfist hardfist is a code owner

Assignees

No one assigned

Labels

release: feature release: feature related release(mr only) team The issue/pr is created by the member of Rspack.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ahabhgk @chenjiahan