Skip to content

feat!: do not expose EsmLibraryPlugin to user directly, use modern-module instead #12792

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
JSerFeng merged 1 commit into from
Jan 21, 2026
Merged

feat!: do not expose EsmLibraryPlugin to user directly, use modern-module instead #12792

JSerFeng merged 1 commit into from
Jan 21, 2026

Conversation

@JSerFeng
Copy link
Contributor

@JSerFeng JSerFeng commented Jan 20, 2026

Summary

Since v2.0, the EsmLibraryPlugin has already been used as the implementation of modern-module, we shouldn't expose this plugin directly to the user but use config instead

Related links

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@JSerFeng JSerFeng requested a review from hardfist as a code owner January 20, 2026 10:53
@netlify
Copy link

netlify bot commented Jan 20, 2026 •
edited
Loading

✅ Deploy Preview for rspack-v2 canceled.

Name Link
🔨 Latest commit 72b6b01
🔍 Latest deploy log https://app.netlify.com/projects/rspack-v2/deploys/6970661bdcb9eb00081554ed

@github-actions github-actions bot added team The issue/pr is created by the member of Rspack. release: feature release: feature related release(mr only) labels Jan 20, 2026
@github-actions
Copy link
Contributor

github-actions bot commented Jan 20, 2026 •
edited
Loading

📦 Binary Size-limit

Comparing 72b6b01 to fix: require.resolve() replaced as require() (#12773) by intellild

🎉 Size decreased by 318.50KB from 47.99MB to 47.68MB (⬇️0.65%)

@JSerFeng JSerFeng requested a review from LingyuCoder as a code owner January 20, 2026 12:08
@github-actions
Copy link
Contributor

github-actions bot commented Jan 20, 2026 •
edited
Loading

Rsdoctor Bundle Diff Analysis

⚠️ Note: The latest commit (5a9e27f883) does not have baseline artifacts. Using commit 48885c75c9 for baseline comparison instead. If this seems incorrect, please wait a few minutes and try rerunning the workflow.

Found 5 projects in monorepo, 5 projects with changes.

📊 Quick Summary
Project Total Size Change
react-10k 5.7 MB -71.0 B (-0.0%)
react-1k 825.3 KB -41.0 B (-0.0%)
react-5k 2.7 MB -60.0 B (-0.0%)
rome 985.8 KB +1.7 KB (0.2%)
ui-components 2.1 MB -30.0 B (-0.0%)
📋 Detailed Reports (Click to expand)

📁 react-10k

Path: ../build-tools-performance/cases/react-10k/dist/rsdoctor-data.json

📌 Baseline Commit: 48885c75c9 | PR: #12773

Metric Current Baseline Change
📊 Total Size 5.7 MB 5.7 MB -71.0 B (-0.0%)
📄 JavaScript 5.7 MB 5.7 MB -71.0 B (-0.0%)
🎨 CSS 21.0 B 21.0 B 0
🌐 HTML 0 B 0 B 0
📁 Other Assets 0 B 0 B 0

📦 Download Diff Report: react-10k Bundle Diff

📁 react-1k

Path: ../build-tools-performance/cases/react-1k/dist/rsdoctor-data.json

📌 Baseline Commit: 48885c75c9 | PR: #12773

Metric Current Baseline Change
📊 Total Size 825.3 KB 825.4 KB -41.0 B (-0.0%)
📄 JavaScript 825.3 KB 825.4 KB -41.0 B (-0.0%)
🎨 CSS 0 B 0 B 0
🌐 HTML 0 B 0 B 0
📁 Other Assets 0 B 0 B 0

📦 Download Diff Report: react-1k Bundle Diff

📁 react-5k

Path: ../build-tools-performance/cases/react-5k/dist/rsdoctor-data.json

📌 Baseline Commit: 48885c75c9 | PR: #12773

Metric Current Baseline Change
📊 Total Size 2.7 MB 2.7 MB -60.0 B (-0.0%)
📄 JavaScript 2.7 MB 2.7 MB -60.0 B (-0.0%)
🎨 CSS 21.0 B 21.0 B 0
🌐 HTML 0 B 0 B 0
📁 Other Assets 0 B 0 B 0

📦 Download Diff Report: react-5k Bundle Diff

📁 rome

Path: ../build-tools-performance/cases/rome/dist/rsdoctor-data.json

📌 Baseline Commit: 48885c75c9 | PR: #12773

Metric Current Baseline Change
📊 Total Size 985.8 KB 984.2 KB +1.7 KB (0.2%)
📄 JavaScript 985.8 KB 984.2 KB +1.7 KB (0.2%)
🎨 CSS 0 B 0 B 0
🌐 HTML 0 B 0 B 0
📁 Other Assets 0 B 0 B 0

📦 Download Diff Report: rome Bundle Diff

📁 ui-components

Path: ../build-tools-performance/cases/ui-components/dist/rsdoctor-data.json

📌 Baseline Commit: 48885c75c9 | PR: #12773

Metric Current Baseline Change
📊 Total Size 2.1 MB 2.1 MB -30.0 B (-0.0%)
📄 JavaScript 2.0 MB 2.0 MB -30.0 B (-0.0%)
🎨 CSS 83.0 KB 83.0 KB 0
🌐 HTML 0 B 0 B 0
📁 Other Assets 0 B 0 B 0

📦 Download Diff Report: ui-components Bundle Diff

Generated by Rsdoctor GitHub Action

@codspeed-hq
Copy link

codspeed-hq bot commented Jan 20, 2026 •
edited
Loading

CodSpeed Performance Report

Merging this PR will degrade performance by 13.51%

Comparing docs/modern-module (72b6b01) with v2 (6dc458e)

Summary

❌ 1 regressed benchmark
✅ 15 untouched benchmarks
⏩ 1 skipped benchmark1

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Benchmark BASE HEAD Efficiency
❌ js@collect imported identifiers 209 µs 241.7 µs -13.51%

Footnotes

  1. 1 benchmark was skipped, so the baseline result was used instead. If it was deleted from the codebase, click here and archive it to remove it from the performance reports. ↩

@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Jan 21, 2026 •
edited
Loading

Deploying rspack-v2 with  Cloudflare Pages  Cloudflare Pages

Latest commit: 72b6b01
Status:🚫  Build failed.

View logs

@JSerFeng JSerFeng merged commit 38997bd into v2 Jan 21, 2026
78 of 81 checks passed
@JSerFeng JSerFeng deleted the docs/modern-module branch January 21, 2026 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Timeless0911 Timeless0911 Timeless0911 approved these changes

@hardfist hardfist Awaiting requested review from hardfist hardfist is a code owner

@LingyuCoder LingyuCoder Awaiting requested review from LingyuCoder LingyuCoder is a code owner

Assignees

No one assigned

Labels

release: feature release: feature related release(mr only) team The issue/pr is created by the member of Rspack.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@JSerFeng @Timeless0911